Repository navigation
WIP: angular1 router - #3138
WIP: angular1 router#3138shahata wants to merge 3 commits into
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
There was a problem hiding this comment.
Shouldn't this method use hasOwnProperty() ?
Same goes for contains() and isEmpty().
There was a problem hiding this comment.
It doesn't really matter in this case; you'll only ever have Objects passed in created by the router itself, so there won't be anything on the prototype unless the user mucks around with Object.prototype.
This file mirrors the implementation of facade/collection.ts.
|
We need to chat about Other than that, we decided to use properties on the controller fn to store annotations, and that we'd convert a template + controller pair into a directive so that we don't have two code paths but can still handle legacy controllers. We also still have lots to do in terms of ergonomics, but if we use fn properties as the canonical storage location, others can build helpers on top to make it nicer to write route configs for Angular 1. |
|
I'm closing this in favor of #3698. Going to finally get this in today. 😄 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.