Conversation
gkalpak
added
action: merge
gkalpak
force-pushed
the
ci-aio-docs-examples-ivy
branch
from
May 21, 2019 15:17
8f49a84 to
2662dae
Compare
3 of 14 tasks
|
You can preview 8f49a84 at https://pr30593-8f49a84.ngbuilds.io/. |
|
You can preview 2662dae at https://pr30593-2662dae.ngbuilds.io/. |
brandonroberts
approved these changes
May 21, 2019
Context: As part of the `test_docs_examples_ivy` job, we run 5 concurrent builds on each VM (each for a different example/project). Additionally, all example projects share the same `node_modules/` (via a symlink to `aio/tools/examples/shared/node_modules/`), so all concurrent builds operate on the same files. Previously, we pre-ran ngcc with `--properties module` to process the fesm5 bundles. Since we have switched to es2015 in 661a57d, we now need the esm2015 bundles. As a result, the initial ngcc run is redundant and ngcc runs again during each build (to process the fesm2015 bundles). Since there are 5 concurrent builds, we often end up with multiple ngcc instances processing the same package and trying to write to the same directories at the same time, causing a `file already exists` error This commit fixes it by pre-processing the esm2015 bundles, so there is no need to re-run ngcc during each concurrent build. Fixes angular#30577
gkalpak
force-pushed
the
ci-aio-docs-examples-ivy
branch
from
May 21, 2019 18:56
2662dae to
c9d1895
Compare
Member
Author
|
FYI: Changed |
|
You can preview c9d1895 at https://pr30593-c9d1895.ngbuilds.io/. |
Contributor
|
This is blocking another release blocker here: #30547 |
jasonaden
pushed a commit
that referenced
this pull request
May 21, 2019
Context: As part of the `test_docs_examples_ivy` job, we run 5 concurrent builds on each VM (each for a different example/project). Additionally, all example projects share the same `node_modules/` (via a symlink to `aio/tools/examples/shared/node_modules/`), so all concurrent builds operate on the same files. Previously, we pre-ran ngcc with `--properties module` to process the fesm5 bundles. Since we have switched to es2015 in 661a57d, we now need the esm2015 bundles. As a result, the initial ngcc run is redundant and ngcc runs again during each build (to process the fesm2015 bundles). Since there are 5 concurrent builds, we often end up with multiple ngcc instances processing the same package and trying to write to the same directories at the same time, causing a `file already exists` error This commit fixes it by pre-processing the esm2015 bundles, so there is no need to re-run ngcc during each concurrent build. Fixes #30577 PR Close #30593
Contributor
|
@benlesh Your CI error looks different than what this PR is fixing |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
As part of the
test_docs_examples_ivyjob, we run 5 concurrent builds on each VM (each for a different example/project). Additionally, all example projects share the samenode_modules/(via a symlink toaio/tools/examples/shared/node_modules/), so all concurrent builds operate on the same files.Previously, we pre-ran ngcc with
--properties moduleto process the fesm5 bundles. Since we have switched to es2015 in 661a57d, we now need the fesm2015 bundles. As a result, the initial ngcc run is redundant and ngcc runs again during each build (to process the fesm2015 bundles). Since there are 5 concurrent builds, we often end up with multiple ngcc instances processing the same package and trying to write to the same directories at the same time, causing afile already existserror.This commit fixes it by pre-processing the fesm2015 bundles, so there is no need to re-run ngcc during each concurrent build.
Fixes #30577.