Conversation
benlesh
added
refactoring
benlesh
force-pushed
the
FW-1337_frog_eyes_forever
branch
from
May 17, 2019 23:36
5514aaf to
4fa0e9d
Compare
kara
suggested changes
May 18, 2019
kara
added
action: cleanup
benlesh
force-pushed
the
FW-1337_frog_eyes_forever
branch
2 times, most recently
from
May 18, 2019 01:50
1edb62e to
e67e01a
Compare
benlesh
changed the title
Contributor
Author
|
I'm really not sure why the bundle size went up so much. It shouldn't have changed much if at all. 🤔 |
Contributor
|
@benlesh it was an issue with the data in the database, restart circleCI and it should be fixed |
JoostK
reviewed
May 20, 2019
There is an encoding issue with using delta `Δ`, where the browser will attempt to detect the file encoding if the character set is not explicitly declared on a `<script/>` tag, and Chrome will find the `Δ` character and decide it is window-1252 encoding, which misinterprets the `Δ` character to be some other character that is not a valid JS identifier character
So back to the frog eyes we go.
```
__
/ɵɵ\
( -- ) - I am ineffable. I am forever.
_/ \_
/ \ / \
== == ==
```
benlesh
force-pushed
the
FW-1337_frog_eyes_forever
branch
from
May 20, 2019 17:48
d86cdba to
d68cb81
Compare
Contributor
Author
kara
added
action: presubmit
benlesh
added
merge: caretaker note
BioPhoton
pushed a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
There is an encoding issue with using delta `Δ`, where the browser will attempt to detect the file encoding if the character set is not explicitly declared on a `<script/>` tag, and Chrome will find the `Δ` character and decide it is window-1252 encoding, which misinterprets the `Δ` character to be some other character that is not a valid JS identifier character
So back to the frog eyes we go.
```
__
/ɵɵ\
( -- ) - I am ineffable. I am forever.
_/ \_
/ \ / \
== == ==
```
PR Close angular#30546
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an encoding issue with using delta
Δ, where the browser will attempt to detect the file encoding if the character set is not explicitly declared on a<script/>tag, and Chrome will find theΔcharacter and decide it is window-1252 encoding, which misinterprets theΔcharacter to be some other character that is not a valid JS identifier characterSo back to the frog eyes we go.