Skip to content

Patch branch: Change ɵɵ instructions to Δ - #30467

Closed
benlesh wants to merge 5 commits into
angular:8.0.xfrom
benlesh:patch-to-delta
Closed

benlesh wants to merge 5 commits into
angular:8.0.xfrom
benlesh:patch-to-delta

Conversation

@benlesh

@benlesh benlesh commented May 14, 2019

Copy link
Copy Markdown
Contributor

The same thing as #30362, only targeting the patch branch.

@benlesh benlesh added refactoring Issue that involves refactoring or code-cleanup PR target: patch-only risk: medium labels May 14, 2019
@ngbot ngbot Bot added this to the needsTriage milestone May 14, 2019
@googlebot

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@benlesh
benlesh changed the base branch from master to 8.0.x May 14, 2019 22:43
@benlesh benlesh added cla: yes and removed cla: no labels May 14, 2019
@googlebot

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@benlesh
benlesh marked this pull request as ready for review May 14, 2019 22:46
@benlesh
benlesh requested a review from IgorMinar as a code owner May 14, 2019 22:46
@benlesh
benlesh requested review from a team May 14, 2019 22:46
@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@IgorMinar

Copy link
Copy Markdown
Contributor

CI is failing due to legit issues.

@benlesh
benlesh requested a review from a team May 15, 2019 17:03
@mary-poppins

Copy link
Copy Markdown

You can preview f8ec317 at https://pr30467-f8ec317.ngbuilds.io/.

@alxhub alxhub added action: merge The PR is ready for merge by the caretaker and removed state: WIP labels May 15, 2019
alxhub pushed a commit that referenced this pull request May 15, 2019
alxhub pushed a commit that referenced this pull request May 15, 2019
alxhub pushed a commit that referenced this pull request May 15, 2019
- They are to be removed before the end of RC

PR Close #30467
@alxhub alxhub closed this May 15, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes refactoring Issue that involves refactoring or code-cleanup risk: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants