refactor(ivy): migrate ɵɵ prefix back to Δ - #30362

presubmit

I see that you just added the PR action: merge label, but the following checks are still failing:
     status "angular" is failing
     status "ci/angular: size" is pending
     status "ci/circleci: integration_test" is pending
     status "ci/circleci: material-unit-tests" is pending
     status "ci/circleci: test" is pending
     status "ci/circleci: test_aio" is pending
     status "ci/circleci: test_aio_local" is pending
     status "ci/circleci: test_aio_local_ivy" is pending
     status "ci/circleci: test_docs_examples" is pending
     status "ci/circleci: test_docs_examples_ivy" is pending
     status "ci/circleci: test_ivy_aot" is pending
     status "google3" is pending
     missing required status "ci/circleci: publish_snapshot"
     1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

The reason the test_aio_local/test_aio_local_ivy jobs (which use the locally built Angular packages) are failing is Material components are trying to import things like ɵɵdefineInjectable and ɵɵinject from @angular/core, which no longer exist (for example see material/esm2015/icons.js).

There are warning about this in the yarn build-local step on the CircleCI job.
No idea why these are just warnings and not hard failures 😕 (It does fail at runtime.)

So, if there are published packages that use ɵɵ-prefixed exports, what is the plan for them with the switch to Δ?
Or is it just material?

UPDATE: Filed angular/angular-cli#14421 to investigate why no hard failures.

Why is material using private APIs? The point of these being private is that we should be able to change them without any issue

@ocombe Material is not using these directly. Since Angular Material uses tree-shakeable injectables which were introduced in V6 (see here), NGC generates ngInjectableDef static class members which rely on the defineInjectable function.

See for example: https://github.com/angular/material2-builds/blob/master/bundles/material-core.umd.js

Ideally the defineInjectable public symbol would have never been prefixed/updated in such a way as it breaks backwards compatibility.

Ugh... I think they were supposed to use defineInjectable which is marked as a @deprecated @publicApi and not @codeGenApi like ɵɵdefineInjectable. 🤦‍♂️

Not sure what to do here. I don't think we want TWO deprecated versions of defineInjectable.

@mhevery?

Who is "they"? According to #30362 (comment), this is ngc's doing (which would imply other 3rd party libraries are affected?).

I'm currently updating a library to compile it with Angular 8 and I believe I face a related issue. ngc from Angular 6 and 7 was emitting:

FaIconService.ngInjectableDef = i0.defineInjectable({ factory: function FaIconService_Factory() { return new FaIconService(); }, token: FaIconService, providedIn: "root" });

While from Angular 8 it emits:

FaIconService.ngInjectableDef = i0.ɵɵdefineInjectable({ factory: function FaIconService_Factory() { return new FaIconService(); }, token: FaIconService, providedIn: "root" });

As far as I can see updating library to Angular 8 forces it to drop support for all previous Angular versions as they don't have ɵɵdefineInjectable function. Just want to double check that this change was intentional?

Okay... so I'm just deprecating ɵɵdefineInjectable and ɵɵinject until we're out of RC, at which point it will be deleted.

@devoto13 The angular team is dedicated to backward compatibility. This is probably just a growing pain with Ivy and the RC. Please file an issue to let us know what problems your experiencing, ideally with a repro. Then you can DM it to me and I'll try to get it escalated so we discuss it. We definitely don't want to break anyone :)

(To DM me, the best bet is twitter, my GitHub notifications are a trainwreck)

newer presubmit

note from multiple 1:1 discussions with @benlesh, @alxhub, @mhevery and @kara: @benlesh is to create a new PR targeting the 8.0.x branch so that we can keep on cherry-picking fixes and infrastructure improvements between the two branches easily.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}