Skip to content

build: update rxjs version requirements to 6.4.0#30032

Closed
benlesh wants to merge 1 commit intoangular:masterfrom
benlesh:rxjs-update
Closed

build: update rxjs version requirements to 6.4.0#30032
benlesh wants to merge 1 commit intoangular:masterfrom
benlesh:rxjs-update

Conversation

@benlesh
Copy link
Copy Markdown
Contributor

@benlesh benlesh commented Apr 22, 2019

Simply moves the needle a bit for RxJS version requirements in angular packages.

@benlesh benlesh added area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime refactoring Issue that involves refactoring or code-cleanup labels Apr 22, 2019
@ngbot ngbot bot added this to the needsTriage milestone Apr 22, 2019
@benlesh benlesh added the target: major This PR is targeted for the next major release label Apr 22, 2019
@benlesh benlesh marked this pull request as ready for review April 22, 2019 17:58
@benlesh benlesh requested review from a team April 22, 2019 17:58
@benlesh benlesh added the action: merge The PR is ready for merge by the caretaker label Apr 22, 2019
IgorMinar
IgorMinar approved these changes Apr 22, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Ben!!

@IgorMinar IgorMinar added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 22, 2019
@IgorMinar
Copy link
Copy Markdown
Contributor

IgorMinar commented Apr 22, 2019

merge-assistance: global approval.

@benlesh benlesh closed this in 94aeeec Apr 22, 2019
@trotyl trotyl mentioned this pull request Apr 23, 2019
Closed
14 tasks
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@benlesh @BioPhoton
build: update rxjs version requirements to 6.4.0 (angular#30032)
c842c5a 
PR Close angular#30032
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@IgorMinar IgorMinar IgorMinar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

3 participants

@benlesh @IgorMinar @googlebot