Skip to content

feat(core): add schematics to move deprecated DOCUMENT import - #29950

Closed
CaerusKaru wants to merge 4 commits into
angular:masterfrom
CaerusKaru:adam/scm-doc
Closed

feat(core): add schematics to move deprecated DOCUMENT import#29950
CaerusKaru wants to merge 4 commits into
angular:masterfrom
CaerusKaru:adam/scm-doc

Conversation

@CaerusKaru

@CaerusKaru CaerusKaru commented Apr 17, 2019

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CaerusKaru
CaerusKaru requested a review from IgorMinar as a code owner April 17, 2019 03:57
@CaerusKaru
CaerusKaru requested a review from a team April 17, 2019 03:57
@CaerusKaru

CaerusKaru commented Apr 17, 2019

Copy link
Copy Markdown
Member Author

After this is merged, we can finally land #28117

alexeagle
alexeagle approved these changes Apr 17, 2019
View reviewed changes
Comment thread packages/core/schematics/migrations/move-document/BUILD.bazel Outdated
Comment thread packages/core/schematics/migrations/move-document/google3/BUILD.bazel Outdated
devversion
devversion reviewed Apr 17, 2019
View reviewed changes

@devversion devversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! early review. You mentioned that there is still work pending to use the ts.Printer. Here are some comments (mostly minor nits)

Comment thread packages/core/schematics/test/move_document_migration_spec.ts Outdated
Comment thread packages/core/schematics/test/move_document_migration_spec.ts Outdated
Comment thread packages/core/schematics/test/google3/move_document_rule_spec.ts Outdated
Comment thread packages/core/schematics/migrations/move-document/google3/moveDocumentRule.ts Outdated
Comment thread packages/core/schematics/migrations/move-document/google3/moveDocumentRule.ts Outdated
Comment thread packages/core/schematics/migrations/move-document/google3/moveDocumentRule.ts Outdated
Comment thread packages/core/schematics/migrations/move-document/document_import_visitor.ts Outdated
Comment thread packages/core/schematics/migrations/move-document/document_import_visitor.ts Outdated
Comment thread packages/core/schematics/migrations/move-document/document_import_visitor.ts Outdated
@benlesh benlesh added the area: core Issues related to the framework runtime label Apr 17, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Apr 17, 2019
@benlesh benlesh added the area: build & ci Related the build and CI infrastructure of the project label Apr 17, 2019
@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Apr 18, 2019
@alexeagle alexeagle added the target: major This PR is targeted for the next major release label Apr 18, 2019
@benlesh benlesh added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 19, 2019
IgorMinar
IgorMinar approved these changes Apr 22, 2019
View reviewed changes

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @CaerusKaru!

@IgorMinar IgorMinar added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 22, 2019
@IgorMinar

IgorMinar commented Apr 22, 2019

Copy link
Copy Markdown
Contributor

merge-assistance: global approval

@benlesh benlesh closed this in 645e305 Apr 22, 2019
@CaerusKaru
CaerusKaru deleted the adam/scm-doc branch April 22, 2019 23:01
@CaerusKaru CaerusKaru mentioned this pull request Apr 23, 2019
Closed
4 of 14 tasks
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@CaerusKaru @BioPhoton
feat(core): add schematics to move deprecated DOCUMENT import (angula…
3ade32b 
…r#29950)

PR Close angular#29950
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes
+2 more reviewers
@alexeagle alexeagle alexeagle approved these changes
@IgorMinar IgorMinar IgorMinar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

6 participants

@CaerusKaru @IgorMinar @alexeagle @devversion @benlesh @googlebot