Skip to content

refactor(ivy): use ɵɵ instead of Δ for now - #29850

Closed
alxhub wants to merge 1 commit into
angular:masterfrom
alxhub:delta_considered_harmful
Closed

refactor(ivy): use ɵɵ instead of Δ for now#29850
alxhub wants to merge 1 commit into
angular:masterfrom
alxhub:delta_considered_harmful

Conversation

@alxhub

@alxhub alxhub commented Apr 11, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

The Δ caused issue with other infrastructure, and we are temporarily
changing it to ɵɵ.

This commit also patches ts_api_guardian_test and AIO to understand ɵɵ.

@alxhub
refactor(ivy): use ɵɵ instead of Δ for now
5d2cdbb 
The `Δ` caused issue with other infrastructure, and we are temporarily
changing it to `ɵɵ`.

This commit also patches ts_api_guardian_test and AIO to understand `ɵɵ`.
@alxhub
alxhub requested a review from IgorMinar as a code owner April 11, 2019 20:50
@alxhub
alxhub requested review from a team April 11, 2019 20:50
kara
kara approved these changes Apr 11, 2019
View reviewed changes

@kara kara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added comp: ivy target: major This PR is targeted for the next major release labels Apr 11, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Apr 11, 2019
@kara kara added the action: presubmit The PR is in need of a google3 presubmit label Apr 11, 2019
@alxhub

alxhub commented Apr 11, 2019

Copy link
Copy Markdown
Member Author

Presubmit

@kara kara added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Apr 11, 2019
@kara

kara commented Apr 11, 2019

Copy link
Copy Markdown
Contributor

merge-assistance: global

@alxhub alxhub closed this in b057806 Apr 11, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@alxhub @wKoza
refactor(ivy): use ɵɵ instead of Δ for now (angular#29850)
71c4afa 
The `Δ` caused issue with other infrastructure, and we are temporarily
changing it to `ɵɵ`.

This commit also patches ts_api_guardian_test and AIO to understand `ɵɵ`.

PR Close angular#29850
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IgorMinar IgorMinar Awaiting requested review from IgorMinar
1 more reviewer
@kara kara kara approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

3 participants

@alxhub @kara @googlebot