Skip to content

refactor(ivy): remove Δ use ɵɵ instead - #29845

Closed
benlesh wants to merge 5 commits into
angular:masterfrom
benlesh:delta_considered_harmful
Closed

refactor(ivy): remove Δ use ɵɵ instead#29845
benlesh wants to merge 5 commits into
angular:masterfrom
benlesh:delta_considered_harmful

Conversation

@benlesh

@benlesh benlesh commented Apr 11, 2019

Copy link
Copy Markdown
Contributor

The delta caused issue with other infrastructure, and we are temporarily changing it to ɵɵ.

Related #29692

@benlesh
refactor(ivy): remove Δ use ɵɵ instead
e9517da 
The delta caused issue with other infrastructure, and we are temporarily changing it to `ɵɵ`.

Related angular#29692
@benlesh
benlesh requested a review from IgorMinar as a code owner April 11, 2019 18:13
@benlesh
benlesh requested review from a team April 11, 2019 18:13
@benlesh benlesh added comp: ivy target: major This PR is targeted for the next major release risk: low refactoring Issue that involves refactoring or code-cleanup labels Apr 11, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Apr 11, 2019
@ocombe

ocombe commented Apr 11, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Didn't we say that we "just" needed to update closure instead of forcing everyone to rebase their PRs two more times?

IgorMinar
IgorMinar suggested changes Apr 11, 2019
View reviewed changes

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR needs a more throughout review that I can do right now. can you please get someone else to do it? Let's keep this PR focused only on the absolutely necessary change and remove all the other changes. Also please make sure we don't accidentally change unrelated files (language service, etc). thanks!

Comment thread docs/PUBLIC_API.md Outdated
Comment thread third_party/github.com/yarnpkg/yarn/releases/download/v1.13.0/bin/yarn.js
Comment thread packages/language-service/test/hover_spec.ts
Comment thread packages/language-service/test/test_data.ts
Comment thread packages/language-service/test/test_utils.ts
Comment thread third_party/github.com/yarnpkg/yarn/releases/download/v1.13.0/bin/yarn.js
@IgorMinar

IgorMinar commented Apr 11, 2019

Copy link
Copy Markdown
Contributor

this PR should be a plan B in case the closure compiler fix can't be made in an expedited manner to unblock the sync...

@benlesh

benlesh commented Apr 11, 2019

Copy link
Copy Markdown
Contributor Author

@ocombe ... I completely agree and understand. And I agree with @IgorMinar

@benlesh benlesh closed this Apr 12, 2019
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@IgorMinar IgorMinar IgorMinar requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@IgorMinar IgorMinar

Labels

cla: yes refactoring Issue that involves refactoring or code-cleanup risk: low target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

4 participants

@benlesh @ocombe @IgorMinar @googlebot