Skip to content

fix(core): resolve ts compile issues due to lenient tsconfig - #29843

Closed
IgorMinar wants to merge 1 commit into
angular:masterfrom
IgorMinar:fix/core-schematics-tsconfig
Closed

fix(core): resolve ts compile issues due to lenient tsconfig#29843
IgorMinar wants to merge 1 commit into
angular:masterfrom
IgorMinar:fix/core-schematics-tsconfig

Conversation

@IgorMinar

@IgorMinar IgorMinar commented Apr 11, 2019

Copy link
Copy Markdown
Contributor

The code failed presubmit in google3 because the original ts config was not as strict
as the one used elsewhere in angular/angular and google3.

@IgorMinar
fix(core): resolve ts compile issues due to lenient tsconfig
4bf917b 
The code failed presubmit in google3 because the original ts config was not as strict
as the one used elsewhere in angular/angular and google3.
@IgorMinar
IgorMinar requested a review from a team April 11, 2019 17:49
@IgorMinar IgorMinar added area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Apr 11, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Apr 11, 2019
@mary-poppins

mary-poppins commented Apr 11, 2019

Copy link
Copy Markdown

You can preview 4bf917b at https://pr29843-4bf917b.ngbuilds.io/.

@IgorMinar IgorMinar closed this in 54058ba Apr 11, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@IgorMinar @wKoza
fix(core): resolve ts compile issues due to lenient tsconfig (angular…
abdf367 
…#29843)

The code failed presubmit in google3 because the original ts config was not as strict
as the one used elsewhere in angular/angular and google3.

PR Close angular#29843
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@gkalpak gkalpak gkalpak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

See More

Successfully merging this pull request may close these issues.

4 participants

@IgorMinar @mary-poppins @gkalpak @googlebot