build(bazel): pin versions of nodejs rules in @angular/bazel peer deps and @bazel/schematics - #29800
Closed
gregmagolan wants to merge 1 commit into
Closed
gregmagolan wants to merge 1 commit into
gregmagolan wants to merge 1 commit into
Conversation
…s and @bazel/schematics
gregmagolan
added
the
area: bazel
gregmagolan
added
the
target: major
kyliau
approved these changes
Apr 10, 2019
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…s and @bazel/schematics (angular#29800) PR Close angular#29800
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since @angular/bazel depends on the internal non-public API of @bazel/typescript and @build_bazel_rules_nodejs we pin the versions of nodejs rules deps in /integration/bazel and in the bazel schematics here to avoid failures like https://circleci.com/gh/angular/angular/278479 after making rules_nodejs releases.
In the future we should consume only the public API of nodejs rules or add a integration test that would catch the above failure in the rules_nodejs repo.