Skip to content

docs: fix wrong header on custom event docs - #29784

Closed
hateonion wants to merge 1 commit into
angular:masterfrom
hateonion:fix-wrong-title-on-custom-event-docs
Closed

hateonion wants to merge 1 commit into
angular:masterfrom
hateonion:fix-wrong-title-on-custom-event-docs

Conversation

@hateonion

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A
Currently, the code example header is wrong in template syntax: customer event section.
image

What is the new behavior?

Change the header from .ts to .html

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@hateonion
hateonion requested a review from a team April 9, 2019 13:30
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@hateonion

Copy link
Copy Markdown
Contributor Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 9, 2019
@brandonroberts brandonroberts self-assigned this Apr 9, 2019
@ngbot ngbot Bot added this to the Backlog milestone Apr 9, 2019

@brandonroberts brandonroberts left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amend git commit message to docs: fix wrong header on custom event docs

@brandonroberts brandonroberts changed the title docs(docs-infra): fix wrong title on custom event docs docs: fix wrong header on custom event docs Apr 9, 2019
@brandonroberts brandonroberts added the target: patch This PR is targeted for the next patch release label Apr 9, 2019
@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label Apr 9, 2019
@brandonroberts
brandonroberts force-pushed the fix-wrong-title-on-custom-event-docs branch from 25e2497 to d7f3043 Compare April 9, 2019 18:55
@brandonroberts brandonroberts added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 9, 2019
@brandonroberts

Copy link
Copy Markdown
Contributor

Caretaker note: I am using a global approval as this is a docs only change

IgorMinar pushed a commit that referenced this pull request Apr 9, 2019
@IgorMinar IgorMinar closed this in b0eefc8 Apr 9, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes effort1: hours merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants