Skip to content

refactor: use new Http library in playground - #29355

Closed
CaerusKaru wants to merge 1 commit into
angular:masterfrom
CaerusKaru:adam/refactor-http
Closed

refactor: use new Http library in playground#29355
CaerusKaru wants to merge 1 commit into
angular:masterfrom
CaerusKaru:adam/refactor-http

Conversation

@CaerusKaru

@CaerusKaru CaerusKaru commented Mar 17, 2019

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CaerusKaru
CaerusKaru requested a review from IgorMinar as a code owner March 17, 2019 03:14
@CaerusKaru CaerusKaru mentioned this pull request Mar 17, 2019
Closed
alexeagle
alexeagle approved these changes Mar 18, 2019
View reviewed changes
Comment thread modules/playground/src/http/app/http_comp.ts
@alexeagle alexeagle added the target: major This PR is targeted for the next major release label Mar 18, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Mar 19, 2019
@IgorMinar IgorMinar added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed target: major This PR is targeted for the next major release labels Apr 26, 2019
@IgorMinar

IgorMinar commented Apr 26, 2019

Copy link
Copy Markdown
Contributor

merge-assistance: no g3 impact

@AndrewKushnir AndrewKushnir added target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release labels Apr 26, 2019
AndrewKushnir pushed a commit that referenced this pull request Apr 26, 2019
@CaerusKaru @AndrewKushnir
refactor: use new Http library in playground (#29355)
908d43a 
PR Close #29355
alexeagle added a commit that referenced this pull request Apr 26, 2019
@alexeagle
Revert "refactor: use new Http library in playground (#29355)"
6816bb6 
This reverts commit 908d43a.
alexeagle added a commit that referenced this pull request Apr 26, 2019
@alexeagle
Revert "refactor: use new Http library in playground (#29355)"
e5c3695 
This reverts commit acfcf90.
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@CaerusKaru @BioPhoton
refactor: use new Http library in playground (angular#29355)
3b8891e 
PR Close angular#29355
BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019
@alexeagle @BioPhoton
Revert "refactor: use new Http library in playground (angular#29355)"
a1bbf78 
This reverts commit acfcf90.
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 15, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@alexeagle alexeagle alexeagle approved these changes
@IgorMinar IgorMinar IgorMinar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

See More

Successfully merging this pull request may close these issues.

6 participants

@CaerusKaru @IgorMinar @alexeagle @mhevery @googlebot @AndrewKushnir