Skip to content

refactor: move DOCUMENT imports from platform-browser to common - #29237

Closed
CaerusKaru wants to merge 1 commit into
angular:masterfrom
CaerusKaru:adam/browser-refactor
Closed

CaerusKaru wants to merge 1 commit into
angular:masterfrom
CaerusKaru:adam/browser-refactor

Conversation

@CaerusKaru

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CaerusKaru
CaerusKaru requested review from a team March 12, 2019 00:21
@kara kara added the area: core Issues related to the framework runtime label Mar 12, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Mar 12, 2019
@CaerusKaru
CaerusKaru force-pushed the adam/browser-refactor branch from fbb7ad0 to 38255e7 Compare March 12, 2019 01:57
@CaerusKaru
CaerusKaru requested a review from a team March 12, 2019 01:57
@CaerusKaru
CaerusKaru force-pushed the adam/browser-refactor branch 2 times, most recently from 6b688de to e69119d Compare March 12, 2019 02:36
@CaerusKaru
CaerusKaru force-pushed the adam/browser-refactor branch 2 times, most recently from a9815b7 to bdc0143 Compare March 12, 2019 21:13
@alexeagle alexeagle added target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Mar 13, 2019
@alexeagle

Copy link
Copy Markdown
Contributor

caretaker assist: has global approval

@alexeagle
alexeagle self-requested a review March 13, 2019 20:57
@CaerusKaru
CaerusKaru force-pushed the adam/browser-refactor branch from bdc0143 to 3fd6157 Compare March 14, 2019 03:26
@CaerusKaru
CaerusKaru requested a review from a team March 14, 2019 03:26
@CaerusKaru

Copy link
Copy Markdown
Member Author

@alexeagle Sorry, missed a couple of uses in some test files. Updated and confirmed no other usages.

@matsko matsko closed this in 7b70760 Mar 14, 2019
@CaerusKaru
CaerusKaru deleted the adam/browser-refactor branch March 14, 2019 20:14
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants