Skip to content

fix(http): status code; test(http): normalize responseText/response; - #2882

Closed
PatrickJS wants to merge 2 commits into
angular:masterfrom
PatrickJS:status-XHRConnection
Closed

PatrickJS wants to merge 2 commits into
angular:masterfrom
PatrickJS:status-XHRConnection

Conversation

@PatrickJS

Copy link
Copy Markdown
Contributor

fix(http): status code; test(http): normalize responseText/response;

  • Tests

closes #2841

@PatrickJS PatrickJS changed the title Status xhr connection fix(http): status code; test(http): normalize responseText/response; Jul 5, 2015
@PatrickJS
PatrickJS force-pushed the status-XHRConnection branch from 727b148 to bc80d66 Compare July 5, 2015 09:28
@tbosch tbosch added action: review The PR is still awaiting reviews from at least one requested reviewer type: bug/fix comp: data-access effort1: hours labels Jul 7, 2015
@PatrickJS
PatrickJS force-pushed the status-XHRConnection branch from bc80d66 to cbedf3d Compare July 10, 2015 09:39
@tbosch

tbosch commented Jul 27, 2015

Copy link
Copy Markdown
Contributor

@gdi2290 What is the status of this PR?

@PatrickJS
PatrickJS force-pushed the status-XHRConnection branch from cbedf3d to 95c1c3c Compare July 27, 2015 23:43
@PatrickJS

Copy link
Copy Markdown
Contributor Author

@tbosch I rebased so it should be good when travis is done

normalize xhr.responseText and xhr.response

- [x] Tests
@PatrickJS
PatrickJS force-pushed the status-XHRConnection branch from 95c1c3c to 19426a6 Compare July 28, 2015 00:01
@PatrickJS

Copy link
Copy Markdown
Contributor Author

@tbosch all green and ready to be merged

@jeffbcross

Copy link
Copy Markdown
Contributor

@gdi2290 thanks, I'll give a final look.

@mhevery mhevery closed this in cfedc77 Aug 4, 2015
@PatrickJS
PatrickJS deleted the status-XHRConnection branch August 4, 2015 01:35
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes effort1: hours type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Http always return status 200

4 participants