Skip to content

fix(router): skipLocationChange with named outlets (patch fix) - #28301

Closed
jasonaden wants to merge 1 commit into
angular:7.2.xfrom
jasonaden:FW-980_fix_named_outlet_patch
Closed

jasonaden wants to merge 1 commit into
angular:7.2.xfrom
jasonaden:FW-980_fix_named_outlet_patch

Conversation

@jasonaden

Copy link
Copy Markdown
Contributor

Patch branch fix for #28300

With angular#27680, a bug was fixed where multiple redirects using `eager` URL update could cause navigation to fail. However, that fix introduced a problem where with `skipLocationChange` enabled, the URL tree rendered was not properly stored for reference. This specifically caused an issue with named router outlets and subsequent navigations not being recognized.

This PR stores the correct `UrlTree` for reference with later navigations. It fixes the regression introdued with angular#27680.

Fixes angular#28200
@jasonaden
jasonaden requested a review from IgorMinar as a code owner January 22, 2019 22:18
@jasonaden
jasonaden requested review from a team January 22, 2019 22:18
@jasonaden
jasonaden changed the base branch from master to 7.2.x January 22, 2019 22:18
@googlebot

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@jasonaden jasonaden added action: merge The PR is ready for merge by the caretaker PR target: patch-only and removed cla: no labels Jan 22, 2019
@ngbot

ngbot Bot commented Jan 22, 2019

Copy link
Copy Markdown

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "cla/google" is failing
    pending missing required labels: cla: yes
    pending status "ci/circleci: test_aio" is pending
    pending status "ci/circleci: build-packages-dist" is pending
    pending status "ci/circleci: test" is pending
    pending status "ci/circleci: legacy-unit-tests-saucelabs" is pending
    pending status "ci/circleci: test_ivy_aot" is pending
    pending status "ci/circleci: legacy-unit-tests-local" is pending
    pending status "ci/circleci: aio_preview" is pending
    pending status "ci/circleci: lint" is pending
    pending status "ci/angular: size" is pending
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@ngbot ngbot Bot added this to the needsTriage milestone Jan 22, 2019
@googlebot

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

alxhub pushed a commit that referenced this pull request Jan 22, 2019
With #27680, a bug was fixed where multiple redirects using `eager` URL update could cause navigation to fail. However, that fix introduced a problem where with `skipLocationChange` enabled, the URL tree rendered was not properly stored for reference. This specifically caused an issue with named router outlets and subsequent navigations not being recognized.

This PR stores the correct `UrlTree` for reference with later navigations. It fixes the regression introdued with #27680.

Fixes #28200

PR Close #28301
@jasonaden

Copy link
Copy Markdown
Contributor Author

Merged in 32737a6.

@jasonaden jasonaden closed this Jan 22, 2019
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: router cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants