fix(ComponentUrlMapper): support relative template URLs in Dartium by munificent · Pull Request #2827 · angular/angular

munificent · 2015-07-01T22:01:51Z

When running in Dartium without using transformers (i.e. with a normal
static web server), handle relative template URLs. This works by using
mirrors to get the URL of the library where the component class is
defined.

When running in Dartium without using transformers (i.e. with a normal static web server), handle relative template URLs. This works by using mirrors to get the URL of the library where the component class is defined.

googlebot · 2015-07-01T22:01:55Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

munificent · 2015-07-01T22:04:20Z

I'm a Googler, but I think I forgot to set the email on this commit to my work account. Either way, I signed the CLA!

googlebot · 2015-07-01T22:04:23Z

CLAs look good, thanks!

vicb · 2015-07-01T22:11:39Z

vicb · 2015-07-01T22:40:03Z

'./component_url_mapper'

Done, thanks!

vicb · 2015-07-01T22:41:51Z

Hopefully fixing the 2 inline comments should make Travis happy.

tbosch · 2015-07-15T00:00:52Z

@munificent what is the status of this?

munificent · 2015-07-15T00:16:31Z

Ugh. Still poking at it to try to get it passing on Travis. :(

I'm not able to reliably run all of the tests locally, so tracking down the Travis failures is slow.

tbosch · 2015-07-16T23:18:02Z

I'm not able to reliably run all of the tests locally

Could you describe your issues? Maybe we can help you / fix these issues?

kegluneq · 2015-07-22T17:43:03Z

/cc @jakemac53

munificent · 2015-07-29T15:10:12Z

Handing this off to Tim since he knows Angular infinitely better than I and I'm not making much progress on it.

tbosch · 2015-08-18T23:30:29Z

@kegluneq Do you want to finish this PR? Or should we close this?

kegluneq · 2015-08-18T23:45:56Z

Don't close it out, I've been preempted whenever I've started looking at this, but I'll finish it.

kegluneq · 2015-09-02T00:25:27Z

Closed by 7c7888d

angular-automatic-lock-bot · 2019-09-07T03:20:26Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

fix(ComponentUrlMapper): support relative template URLs in Dartium

7d68acb

When running in Dartium without using transformers (i.e. with a normal static web server), handle relative template URLs. This works by using mirrors to get the URL of the library where the component class is defined.

googlebot added the cla: no label Jul 1, 2015

googlebot added cla: yes and removed cla: no labels Jul 1, 2015

vicb reviewed Jul 1, 2015
View reviewed changes

vicb added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jul 1, 2015

vicb reviewed Jul 1, 2015
View reviewed changes

IgorMinar force-pushed the master branch from 83e628b to a7ea2e5 Compare July 3, 2015 06:21

munificent added 4 commits July 8, 2015 11:06

Remove dead code and fix relative import URL.

d21b923

Remove another unused import.

3e243cd

Merge branch 'master' into mirrors-relative

f069395

Merge branch 'master' into mirrors-relative

9bb138f

munificent mentioned this pull request Jul 13, 2015

Support relative urls in dart #2771

Closed

munificent added 2 commits July 13, 2015 16:53

Merge branch 'master' into mirrors-relative

dd1d31f

Resolve relative URIs correctly in material examples.

c8aa7e1

tbosch assigned munificent Jul 15, 2015

Merge branch 'master' into mirrors-relative

9536237

munificent added 2 commits July 23, 2015 13:58

Merge branch 'master' into mirrors-relative

69b3ec5

Handle the URLs we get for components from dart2js mirrors.

eaeee89

munificent assigned kegluneq and unassigned munificent Jul 29, 2015

kegluneq mentioned this pull request Aug 20, 2015

fix(ComponentUrlMapper): support relative template URLs in Dartium #3743

Closed

mhevery added state: Periodic Review and removed state: Periodic Review labels Aug 20, 2015

kegluneq closed this Sep 2, 2015

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019

Conversation

munificent commented Jul 1, 2015

Uh oh!

googlebot commented Jul 1, 2015

Uh oh!

munificent commented Jul 1, 2015

Uh oh!

googlebot commented Jul 1, 2015

Uh oh!

vicb Jul 1, 2015

Choose a reason for hiding this comment

Uh oh!

munificent Jul 8, 2015

Choose a reason for hiding this comment

Uh oh!

vicb Jul 1, 2015

Choose a reason for hiding this comment

Uh oh!

munificent Jul 8, 2015

Choose a reason for hiding this comment

Uh oh!

vicb commented Jul 1, 2015

Uh oh!

tbosch commented Jul 15, 2015

Uh oh!

munificent commented Jul 15, 2015

Uh oh!

tbosch commented Jul 16, 2015

Uh oh!

kegluneq commented Jul 22, 2015

Uh oh!

munificent commented Jul 29, 2015

Uh oh!

tbosch commented Aug 18, 2015

Uh oh!

kegluneq commented Aug 18, 2015

Uh oh!

kegluneq commented Sep 2, 2015

Uh oh!

angular-automatic-lock-bot Bot commented Sep 7, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants