ci: move the remaining travis tests to circle #27937
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -218,11 +218,12 @@ jobs: | |
| - run: yarn --cwd aio tools-test | ||
| - run: ./aio/aio-builds-setup/scripts/test.sh | ||
|
|
||
| test_docs_examples: | ||
| <<: *job_defaults | ||
| docker: | ||
| # Needed because the example e2e tests depend on Chrome. | ||
| - image: *browsers_docker_image | ||
| parallelism: 3 | ||
| steps: | ||
| - checkout: | ||
| <<: *post_checkout | ||
|
|
@@ -235,28 +236,10 @@ jobs: | |
| - *yarn_install | ||
| # Install aio | ||
| - run: yarn --cwd aio install --frozen-lockfile --non-interactive | ||
| # Run examples tests. The "CIRCLE_NODE_INDEX" will be set if "parallelism" is enabled. | ||
| # Since the parallelism is set to "3", there will be three parallel CircleCI containers | ||
| # with either "0", "1" or "2" as node index. This can be passed to the "--shard" argument. | ||
| - run: yarn --cwd aio example-e2e --setup --local --shard=${CIRCLE_NODE_INDEX}/${CIRCLE_NODE_TOTAL} | ||
|
|
||
| # This job should only be run on PR builds, where `CI_PULL_REQUEST` is not `false`. | ||
| aio_preview: | ||
|
|
@@ -333,6 +316,7 @@ jobs: | |
| # See comments inside the integration/run_tests.sh script. | ||
| integration_test: | ||
| <<: *job_defaults | ||
| parallelism: 4 | ||
| docker: | ||
| # Needed because the integration tests expect Chrome to be installed (e.g cli-hello-world) | ||
| - image: *browsers_docker_image | ||
|
|
@@ -348,7 +332,9 @@ jobs: | |
| - attach_workspace: | ||
| at: dist | ||
| - *define_env_vars | ||
| # Runs the integration tests in parallel across multiple CircleCI container instances. The | ||
| # amount of container nodes for this job is controlled by the "parallelism" option. | ||
| - run: ./integration/run_tests.sh ${CIRCLE_NODE_INDEX} ${CIRCLE_NODE_TOTAL} | ||
|
|
||
| # This job updates the content of repos like github.com/angular/core-builds | ||
| # for every green build on angular/angular. | ||
|
|
@@ -399,6 +385,95 @@ jobs: | |
| command: 'curl --request POST --header "Content-Type: application/json" --data "{\"text\":\":x: \`$CIRCLE_JOB\` job failed on build $CIRCLE_BUILD_NUM: $CIRCLE_BUILD_URL :scream:\"}" $CI_SECRET_SLACK_CARETAKER_WEBHOOK_URL' | ||
| when: on_fail | ||
|
|
||
| legacy-unit-tests-local: | ||
| <<: *job_defaults | ||
| docker: | ||
| - image: *browsers_docker_image | ||
| steps: | ||
| - checkout: | ||
| <<: *post_checkout | ||
| - restore_cache: | ||
| key: *cache_key | ||
| - *define_env_vars | ||
| - *yarn_install | ||
| - run: yarn tsc -p packages | ||
| - run: yarn tsc -p packages/examples | ||
| - run: yarn tsc -p modules | ||
| - run: yarn karma start ./karma-js.conf.js --single-run --browsers=ChromeNoSandbox | ||
|
|
||
| legacy-unit-tests-saucelabs: | ||
| <<: *job_defaults | ||
| # In order to avoid the bottleneck of having a slow host machine, we acquire a better | ||
| # container for this job. This is necessary because we launch a lot of browsers concurrently | ||
| # and therefore the tunnel and Karma need to process a lot of file requests and tests. | ||
| resource_class: xlarge | ||
| steps: | ||
| - checkout: | ||
| <<: *post_checkout | ||
| - restore_cache: | ||
| key: *cache_key | ||
| - *define_env_vars | ||
|
devversion marked this conversation as resolved.
Outdated
|
||
| - *yarn_install | ||
| - run: | ||
| name: Preparing environment for running tests on Saucelabs. | ||
| command: | | ||
| setPublicVar KARMA_JS_BROWSERS $(node -e 'console.log(require("./browser-providers.conf").sauceAliases.CI_REQUIRED.join(","))') | ||
| setSecretVar SAUCE_ACCESS_KEY $(echo $SAUCE_ACCESS_KEY | rev) | ||
| - run: | ||
| name: Starting Saucelabs tunnel | ||
| command: ./scripts/saucelabs/start-tunnel.sh | ||
| background: true | ||
| - run: yarn tsc -p packages | ||
| - run: yarn tsc -p packages/examples | ||
| - run: yarn tsc -p modules | ||
| # Waits for the Saucelabs tunnel to be ready. This ensures that we don't run tests | ||
| # too early without Saucelabs not being ready. | ||
| - run: ./scripts/saucelabs/wait-for-tunnel.sh | ||
| - run: yarn karma start ./karma-js.conf.js --single-run --browsers=${KARMA_JS_BROWSERS} | ||
| - run: ./scripts/saucelabs/stop-tunnel.sh | ||
|
|
||
| legacy-e2e-tests: | ||
| <<: *job_defaults | ||
| docker: | ||
| - image: *browsers_docker_image | ||
| steps: | ||
| - checkout: | ||
| <<: *post_checkout | ||
| - restore_cache: | ||
| key: *cache_key | ||
| - *define_env_vars | ||
| - *setup_circleci_bazel_config | ||
| - *yarn_install | ||
| - *setup_bazel_remote_execution | ||
| - attach_workspace: | ||
| at: dist | ||
| # Build the e2e tests using the existing Bazel "packages-dist" output that has been | ||
| # attached to this job. This avoids multiple rebuilds across various CI jobs. | ||
| - run: ./scripts/build-e2e-tests.sh --use-existing-packages-dist | ||
| - run: | ||
| name: Starting servers for e2e tests | ||
| command: yarn gulp serve serve-examples | ||
| background: true | ||
| - run: NODE_PATH=$NODE_PATH:./dist/all yarn protractor ./protractor-e2e.conf.js --bundles=true | ||
| - run: NODE_PATH=$NODE_PATH:./dist/all yarn protractor ./protractor-examples-e2e.conf.js --bundles=true | ||
| - run: NODE_PATH=$NODE_PATH:./dist/all yarn protractor ./protractor-perf.conf.js --bundles=true --dryrun | ||
|
|
||
| legacy-misc-tests: | ||
| <<: *job_defaults | ||
| steps: | ||
| - checkout: | ||
| <<: *post_checkout | ||
| - restore_cache: | ||
| key: *cache_key | ||
| - *define_env_vars | ||
| - *yarn_install | ||
| - attach_workspace: | ||
| at: dist | ||
| - run: yarn gulp check-cycle | ||
| # TODO: disabled because the Bazel packages-dist does not seem to have map files for | ||
| # the ESM5/ES2015 output. See: https://github.com/angular/angular/issues/27966 | ||
| # - run: yarn gulp source-map-test | ||
|
devversion marked this conversation as resolved.
Outdated
|
||
|
|
||
| workflows: | ||
|
IgorMinar marked this conversation as resolved.
Outdated
|
||
| version: 2 | ||
| default_workflow: | ||
|
|
@@ -408,19 +483,24 @@ workflows: | |
| - test_ivy_aot | ||
| - build-packages-dist | ||
| - test_aio | ||
| - legacy-unit-tests-local | ||
| - legacy-unit-tests-saucelabs | ||
| - deploy_aio: | ||
| requires: | ||
| - test_aio | ||
| - legacy-e2e-tests: | ||
| requires: | ||
| - build-packages-dist | ||
| - legacy-misc-tests: | ||
| requires: | ||
| - build-packages-dist | ||
| - test_aio_local: | ||
| requires: | ||
| - build-packages-dist | ||
| - test_aio_tools: | ||
| requires: | ||
| - build-packages-dist | ||
| - test_docs_examples: | ||
| requires: | ||
| - build-packages-dist | ||
| - aio_preview: | ||
|
|
@@ -446,11 +526,15 @@ workflows: | |
| - integration_test | ||
| # Only publish if `aio`/`docs` tests using the locally built Angular packages pass | ||
| - test_aio_local | ||
| - test_docs_examples | ||
| # Get the artifacts to publish from the build-packages-dist job | ||
| # since the publishing script expects the legacy outputs layout. | ||
| - build-packages-dist | ||
| - legacy-e2e-tests | ||
|
devversion marked this conversation as resolved.
Outdated
|
||
| - legacy-misc-tests | ||
| - legacy-unit-tests-local | ||
| - legacy-unit-tests-saucelabs | ||
|
|
||
|
|
||
| aio_monitoring: | ||
| jobs: | ||
|
|
@@ -462,3 +546,9 @@ workflows: | |
| branches: | ||
| only: | ||
| - master | ||
|
|
||
| # TODO: | ||
| # - don't build the g3 branch | ||
| # - verify that we are bootstrapping with the right yarn version coming from the docker image | ||
| # - check local chrome version pulled from docker image | ||
| # - remove /tools/ngcontainer | ||
|
Member
There was a problem hiding this comment. Create a GitHub or Jira issue (and mention it here)?
Member
There was a problem hiding this comment. @gkalpak It's not planned to address this as part of this PR, unless @IgorMinar wants me to do that. I think tracking this fits better into JIRA, so someone who has access needs to create one. Maybe Alex already has something on this list?
Member
There was a problem hiding this comment. @devversion, sorry for the late response. Are you (or anyone else) working on these or should we create a Jira issue to track?
Member
There was a problem hiding this comment. @gkalpak No problem 😄 I'm currently not working on these, nor we have these tracked anywhere yet (except in this file). Agreed, I think it would be good to move these to JIRA. I personally would like to be involved with the removal of |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,8 @@ echo "source $envHelpersPath;" >> $BASH_ENV; | |
| #################################################################################################### | ||
| # Define PUBLIC environment variables for CircleCI. | ||
| #################################################################################################### | ||
| # See https://circleci.com/docs/2.0/env-vars/#built-in-environment-variables for more info. | ||
| #################################################################################################### | ||
| setPublicVar PROJECT_ROOT "$(pwd)"; | ||
| setPublicVar CI_AIO_MIN_PWA_SCORE "95"; | ||
| # This is the branch being built; e.g. `pull/12345` for PR builds. | ||
|
|
@@ -31,5 +33,26 @@ setSecretVar CI_SECRET_PAYLOAD_FIREBASE_TOKEN "$ANGULAR_PAYLOAD_TOKEN"; | |
| setSecretVar CI_SECRET_SLACK_CARETAKER_WEBHOOK_URL "$SLACK_CARETAKER_WEBHOOK_URL"; | ||
|
|
||
|
|
||
| #################################################################################################### | ||
| # Define SauceLabs environment variables for CircleCI. | ||
| #################################################################################################### | ||
| # In order to have a meaningful SauceLabs badge on the repo page, | ||
| # the angular2-ci account is used only when pushing commits to master; | ||
| # in all other cases, the regular angular-ci account is used. | ||
| if [ "${CI_PULL_REQUEST}" = "false" ] && [ "${CI_REPO_OWNER}" = "angular" ] && [ "${CI_BRANCH}" = "master" ]; then | ||
| setPublicVar SAUCE_USERNAME "angular2-ci"; | ||
| setSecretVar SAUCE_ACCESS_KEY "693ebc16208a-0b5b-1614-8d66-a2662f4e"; | ||
|
Member
There was a problem hiding this comment. Should this be a hidden var (i.e. set in CircleCI project settings)?
Member
There was a problem hiding this comment. cc. @IgorMinar. I think this is reasonable. This would ensure that the Saucelabs badge is 100% based on the results of the |
||
| else | ||
| setPublicVar SAUCE_USERNAME "angular-ci"; | ||
| setSecretVar SAUCE_ACCESS_KEY "9b988f434ff8-fbca-8aa4-4ae3-35442987"; | ||
| fi | ||
| setPublicVar SAUCE_READY_FILE /tmp/angular/sauce-connect-ready-file.lock | ||
| setPublicVar SAUCE_PID_FILE /tmp/angular/sauce-connect-pid-file.lock | ||
| setPublicVar SAUCE_TUNNEL_IDENTIFIER "angular-${CIRCLE_BUILD_NUM}-${CIRCLE_NODE_INDEX}" | ||
| # Amount of seconds we wait for sauceconnect to establish a tunnel instance. In order to not | ||
| # acquire CircleCI instances for too long if sauceconnect failed, we need a connect timeout. | ||
| setPublicVar SAUCE_READY_FILE_TIMEOUT 120 | ||
|
|
||
|
|
||
| # Source `$BASH_ENV` to make the variables available immediately. | ||
| source $BASH_ENV; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.