ci: move the remaining travis tests to circle by IgorMinar · Pull Request #27937 · angular/angular

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

mary-poppins · 2019-01-05T10:17:39Z

You can preview f026b19 at https://pr27937-f026b19.ngbuilds.io/.

mary-poppins · 2019-01-05T10:23:52Z

You can preview 969199f at https://pr27937-969199f.ngbuilds.io/.

mary-poppins · 2019-01-05T10:44:48Z

You can preview df5edde at https://pr27937-df5edde.ngbuilds.io/.

mary-poppins · 2019-01-05T10:51:33Z

You can preview fcda67b at https://pr27937-fcda67b.ngbuilds.io/.

mary-poppins · 2019-01-05T11:00:37Z

You can preview 39557e7 at https://pr27937-39557e7.ngbuilds.io/.

mary-poppins · 2019-01-05T11:13:09Z

You can preview 9e9d4fa at https://pr27937-9e9d4fa.ngbuilds.io/.

mary-poppins · 2019-01-07T19:16:11Z

You can preview 8b26cc2 at https://pr27937-8b26cc2.ngbuilds.io/.

googlebot · 2019-01-07T19:18:23Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

alexeagle

I think developer.md needs a bunch more work, but maybe in a follow-up PR since this is close to landing.
should just be yarn build, yarn test, yarn e2e and I don't see why ppl want to wait to build the real npm packages, what's the workflow for that?
Let's go through it together?

I believe all the feedback from George has been addressed already.

the metadata build seems to be needed only by the offline compiler tests which is currently disabled PR Close #27937

PR Close #27937

we no longer need it... yay!!! PR Close #27937

test.sh is no longer needed... all the tests should now be executed via bazel. if for whatever reason we need to run the legacy unit test setup, we should should follow the commands that we use to execute those tests in .circle/config.yaml PR Close #27937

this script is now obsolete and not needed any more. yay!!! PR Close #27937

…ode devDep (#27937) I'm not sure why this problem is visible only now or how this worked before, but the CI is now failing because @types/node is missing. I also added the yarn.lock file which was previously omitted. We want the yarn.lock file in so that our deps don't change over time without us knowing. PR Close #27937

PR Close #27937

* Groups the two sharded `test_docs_examples` job using CircleCI's `parallelism` feature. This makes the amount of jobs that show up on a PR, more reduced and also reduces code duplication for maintaining the Circle job definition. PR Close #27937

PR Close #27937

@gregmagolan

Moving the tests over to CircleCI in pretty much "as-is" state just so that we can drop the dependency on Travis. In the followup changes we plan to migrate these tests to run on sauce under bazel. @gregmagolan is working on that. I've previously verified that all the tests executed in legacy-unit-tests-local already under bazel. Therefore the legacy-unit-tests-local job is strictly not necessary any more, but given how flaky legacy-unit-tests-saucelabs is, it is good to have the -local job just so that we can quickly determine if any failure is a flake or legit issue (the bazel version of these tests could theoretically run in a slightly different way and fail or not fail in a different way, so having -lcoal job is just an extra safety check). This change was coauthored with @devversion PR Close #27937

the metadata build seems to be needed only by the offline compiler tests which is currently disabled PR Close #27937

IgorMinar · 2019-01-13T07:42:53Z

We can't remove ngcontainer yet. I talked to AlexE. Too many other repos need it.

…

On Sat, Jan 12, 2019, 1:38 PM Paul Gschwendtner ***@***.*** wrote: ***@***.**** commented on this pull request. ------------------------------ In .circleci/config.yml <#27937 (comment)>: > @@ -462,3 +513,9 @@ workflows: branches: only: - master + +# TODO: +# - don't build the g3 branch +# - verify that we are bootstrapping with the right yarn version coming from the docker image +# - check local chrome version pulled from docker image +# - remove /tools/ngcontainer @gkalpak <https://github.com/gkalpak> No problem 😄 I'm currently not working on these, nor we have these tracked anywhere yet (except in this file). Agreed, I think it would be good to move these to JIRA. I personally would like to be involved with the removal of ngcontainer since we still use it on Material and I've been trying to remove it already in #26691 <#26691>. If you create one, can you mention that Material still depends on it atm? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27937 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANM6FQmBkpSU-HJgUJkCq6e2Ukg_65Eks5vClXngaJpZM4ZskeU> .

angular-automatic-lock-bot · 2019-09-14T12:53:26Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jan 4, 2019

IgorMinar commented Jan 4, 2019

View reviewed changes

Comment thread scripts/sauce/sauce_connect_wait_for_tunnel.sh Outdated

IgorMinar requested a review from devversion January 4, 2019 20:31

IgorMinar commented Jan 4, 2019

View reviewed changes

Comment thread .circleci/config.yml Outdated

kara added the area: build & ci Related the build and CI infrastructure of the project label Jan 4, 2019

ngbot Bot added this to the needsTriage milestone Jan 4, 2019

devversion force-pushed the ci/travis-thanks-for-all-the-fish branch from 5aab8e4 to f026b19 Compare January 5, 2019 10:14

googlebot added cla: no and removed cla: yes labels Jan 5, 2019

build: increase parallelism for "test_docs_examples" job

8b26cc2

devversion force-pushed the ci/travis-thanks-for-all-the-fish branch from fab1b76 to 8b26cc2 Compare January 7, 2019 19:06

IgorMinar added cla: yes and removed cla: no labels Jan 7, 2019

alexeagle approved these changes Jan 7, 2019

View reviewed changes

IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 7, 2019

kara closed this in 04ca3bc Jan 7, 2019

kara pushed a commit that referenced this pull request Jan 7, 2019

ci: remove build steps that are no longer needed (#27937)

bb5ddee

the metadata build seems to be needed only by the offline compiler tests which is currently disabled PR Close #27937

kara pushed a commit that referenced this pull request Jan 7, 2019

ci: move e2e tests from travis to circleci (#27937)

7de7b7a

PR Close #27937

kara pushed a commit that referenced this pull request Jan 7, 2019

ci: run legacy e2e tests in parallel (#27937)

17291e6

PR Close #27937

kara pushed a commit that referenced this pull request Jan 7, 2019

ci: remove travis ci setup (#27937)

0199e26

we no longer need it... yay!!! PR Close #27937

kara pushed a commit that referenced this pull request Jan 7, 2019

build: remove "build.sh" script (#27937)

98472da

this script is now obsolete and not needed any more. yay!!! PR Close #27937

kara pushed a commit that referenced this pull request Jan 7, 2019

build: shard integration tests on circleci (#27937)

4fc4151

PR Close #27937

kara pushed a commit that referenced this pull request Jan 7, 2019

build: bazel integration test using limited resources (#27937)

b47c43a

PR Close #27937

kara pushed a commit that referenced this pull request Jan 7, 2019

build: increase parallelism for "test_docs_examples" job (#27937)

483f825

PR Close #27937

kara pushed a commit that referenced this pull request Jan 7, 2019

ci: remove build steps that are no longer needed (#27937)

11fe52b

the metadata build seems to be needed only by the offline compiler tests which is currently disabled PR Close #27937

This was referenced Jan 7, 2019

integration_test job on CircleCI takes too long (much longer than other jobs) #27663

Closed

Build infrastructure improvements #21707

Closed

gkalpak mentioned this pull request Jan 8, 2019

FW-517 & FW-536: private directive issues #27743

Closed

devversion mentioned this pull request Jan 9, 2019

Better log output for Saucelabs connect tunnel #27691

Closed

Conversation

IgorMinar commented Jan 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mary-poppins commented Jan 4, 2019

Uh oh!

Uh oh!

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

googlebot commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 5, 2019

Uh oh!

mary-poppins commented Jan 7, 2019

Uh oh!

googlebot commented Jan 7, 2019

Uh oh!

alexeagle left a comment

Choose a reason for hiding this comment

Uh oh!

IgorMinar commented Jan 13, 2019 via email

Uh oh!

angular-automatic-lock-bot Bot commented Sep 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

IgorMinar commented Jan 4, 2019 •

edited

Loading