Conversation
…w injector integration)
|
You can preview afa8bf0 at https://pr27912-afa8bf0.ngbuilds.io/. |
marclaval
changed the title
|
You can preview a4e5ba0 at https://pr27912-a4e5ba0.ngbuilds.io/. |
| expect(purePipe3).toBe(purePipe1); | ||
| expect(purePipe4).toBe(purePipe1); | ||
| }); | ||
| fixmeIvy('FW-821: Pure pipes are instantiated differently in view engine and ivy') |
Member
There was a problem hiding this comment.
This should be modifiedInIvy, no? My understanding is that we've decided that it is a deliberate breaking change so nothing to "fix" here.
marclaval
added
action: review
|
You can preview 34539fc at https://pr27912-34539fc.ngbuilds.io/. |
mhevery
approved these changes
Jan 3, 2019
mhevery
added
action: merge
benlesh
pushed a commit
that referenced
this pull request
Jan 3, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FW-890 seems to be no longer be an issue.
Only the last commit has to be reviewed.