Skip to content

docs(forms): update desc for hasError and getError - #27861

Closed
kara wants to merge 2 commits into
angular:masterfrom
kara:hasError
Closed

docs(forms): update desc for hasError and getError#27861
kara wants to merge 2 commits into
angular:masterfrom
kara:hasError

Conversation

@kara

@kara kara commented Dec 28, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

This commit adds docs for the changes made in #20211 (should be merged after #20211).

Closes #19734.

cc @Toxicable

@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer area: forms target: major This PR is targeted for the next major release labels Dec 28, 2018
@ngbot ngbot Bot added this to the needsTriage milestone Dec 28, 2018
@kara
kara requested a review from IgorMinar December 28, 2018 19:15
@mary-poppins

mary-poppins commented Dec 28, 2018

Copy link
Copy Markdown

You can preview d60cf75 at https://pr27861-d60cf75.ngbuilds.io/.

@kara
docs(forms): update desc for hasError and getError
11556b2 
This commit adds docs for the changes made in angular#20211.

Closes angular#19734.
@mary-poppins

mary-poppins commented Dec 28, 2018

Copy link
Copy Markdown

You can preview 11556b2 at https://pr27861-11556b2.ngbuilds.io/.

IgorMinar
IgorMinar approved these changes Dec 28, 2018
View reviewed changes

@IgorMinar IgorMinar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up. Otherwise lgtm.

Comment thread packages/forms/src/model.ts Outdated
Comment thread packages/forms/src/directives/abstract_control_directive.ts
Comment thread packages/forms/src/directives/abstract_control_directive.ts Outdated
Comment thread packages/forms/src/directives/abstract_control_directive.ts Outdated
Comment thread packages/forms/src/directives/abstract_control_directive.ts Outdated
@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 28, 2018
@kara kara removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 28, 2018
@mary-poppins

mary-poppins commented Dec 28, 2018

Copy link
Copy Markdown

You can preview b4a0d93 at https://pr27861-b4a0d93.ngbuilds.io/.

@kara kara added the action: merge The PR is ready for merge by the caretaker label Dec 28, 2018
@kara

kara commented Dec 28, 2018

Copy link
Copy Markdown
Contributor Author

Caretaker note: this is ready to go, but must be merged after 20211

@benlesh benlesh closed this in e268a05 Jan 3, 2019
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@IgorMinar IgorMinar IgorMinar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: forms cla: yes state: blocked target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

Change the getError and hasError signature to have more flexibility

4 participants

@kara @mary-poppins @IgorMinar @googlebot