Skip to content

test(ivy): add root cause analysis for failing core tests (view injec… - #27802

Closed
marclaval wants to merge 3 commits into
angular:masterfrom
marclaval:coreRCA
Closed

test(ivy): add root cause analysis for failing core tests (view injec…#27802
marclaval wants to merge 3 commits into
angular:masterfrom
marclaval:coreRCA

Conversation

@marclaval

@marclaval marclaval commented Dec 21, 2018

Copy link
Copy Markdown
Contributor

…tor integration)

@mary-poppins

mary-poppins commented Dec 21, 2018

Copy link
Copy Markdown

You can preview e38fdf0 at https://pr27802-e38fdf0.ngbuilds.io/.

@marclaval marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Dec 21, 2018
@ngbot ngbot Bot added this to the needsTriage milestone Dec 21, 2018
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 21, 2018
@kara kara removed the action: merge The PR is ready for merge by the caretaker label Dec 21, 2018
kara
kara previously requested changes Dec 21, 2018
View reviewed changes
Comment thread packages/core/test/linker/view_injector_integration_spec.ts Outdated
Comment thread packages/core/test/linker/view_injector_integration_spec.ts Outdated
Comment thread packages/core/test/linker/view_injector_integration_spec.ts Outdated
@kara kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 21, 2018
@mary-poppins

mary-poppins commented Jan 2, 2019

Copy link
Copy Markdown

You can preview 04efbc3 at https://pr27802-04efbc3.ngbuilds.io/.

@marclaval marclaval added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 2, 2019
@mary-poppins

mary-poppins commented Jan 3, 2019

Copy link
Copy Markdown

You can preview 8901fe9 at https://pr27802-8901fe9.ngbuilds.io/.

@mhevery
mhevery dismissed kara’s stale review January 3, 2019 17:19

Kara's concerned resolved. She is on vacation, dismissing her review.

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 3, 2019
@AndrewKushnir

AndrewKushnir commented Jan 4, 2019

Copy link
Copy Markdown
Contributor

@marclaval could you please rebase from the latest master and resolve conflict (and add "merge" label back)? Thank you.

@AndrewKushnir AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jan 4, 2019
@marclaval

marclaval commented Jan 4, 2019

Copy link
Copy Markdown
Contributor Author

No longer relevant, it was merged with #27912

@marclaval marclaval closed this Jan 4, 2019
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 14, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@mhevery mhevery mhevery approved these changes
@kara kara kara left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

See More

@marclaval marclaval

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

6 participants

@marclaval @mary-poppins @AndrewKushnir @mhevery @kara @googlebot