Conversation
|
You can preview 89a02b0 at https://pr27764-89a02b0.ngbuilds.io/. |
2 of 12 tasks
alexeagle
pushed a commit
to bazel-contrib/rules_nodejs
that referenced
this pull request
Dec 20, 2018
Given `'rxjs/ajax/index.js'` as `path`, and the following resolutions:
```
var MODULE_ROOTS = [
{module_name: /^rxjs\/ajax\/\b/, module_root: 'rxjs/ajax/'},
{module_name: /^rxjs\/ajax\b/, module_root: 'rxjs/ajax/index.js'},
]
```
The current algorithm would disregard the first match because it left the string unchanged, even though it was the longest regex.
This caused it to return `rxjs/ajax/index.js/index.js` instead of `rxjs/ajax/index.js`.
Followup to #474, related to a failure observed in angular/angular#27764.
This includes a performance fix for module resolution in the common case under Ivy
alexeagle
force-pushed
the
update_nodejs
branch
from
December 20, 2018 20:14
89a02b0 to
1a43077
Compare
filipesilva
approved these changes
Dec 20, 2018
|
You can preview 1a43077 at https://pr27764-1a43077.ngbuilds.io/. |
alexeagle
added
action: merge
filipesilva
approved these changes
Dec 20, 2018
benlesh
pushed a commit
that referenced
this pull request
Dec 26, 2018
This includes a performance fix for module resolution in the common case under Ivy PR Close #27764
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a performance fix for module resolution in the common case under Ivy