fix(ivy): apply all overrides from TestBed, not the last one only - #27734
Closed
AndrewKushnir wants to merge 1 commit into
Closed
AndrewKushnir wants to merge 1 commit into
AndrewKushnir wants to merge 1 commit into
Conversation
In some cases in our tests we can define multiple overrides for a given class. As a result, only the last override is actually applied due to the fact that we store overrides in a Type<->Override map. This update changes the logic to keep all overrides defined in a given test for a Type (i.e. Type<->Override[] map) and applies them one by one at resolution phase. This behavior is more inline with the previous TestBed.
AndrewKushnir
added
type: bug/fix
area: testing
|
You can preview 9a8b4fc at https://pr27734-9a8b4fc.ngbuilds.io/. |
kara
approved these changes
Dec 18, 2018
alxhub
reviewed
Dec 19, 2018
| compFixture.detectChanges(); | ||
| expect(compFixture.nativeElement).toHaveText('transformed hello'); | ||
| }); | ||
| it('should work', () => { |
alxhub
approved these changes
Dec 19, 2018
Contributor
Author
AndrewKushnir
added
action: merge
matsko
added a commit
to matsko/angular
that referenced
this pull request
Dec 26, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases in our tests we can define multiple overrides for a given class. As a result, only the last override is actually applied due to the fact that we store overrides in a
Type<->Overridemap. This update changes the logic to keep all overrides defined in a given test for a Type (i.e.Type<->Override[]map) and applies them one by one at resolution phase. This behavior is more inline with the previous TestBed.An example test case (from
packages/platform-browser/test/testing_public_spec.ts) that was failing is:As a result, the
pureflag was changed, but thenameremained the same, because the name-related override was replaced by the second one that sets thepureflag.This PR resolves FW-852.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?