Skip to content

feat(router): support deep-linking to anywhere in the app - #2772

Merged
btford merged 2 commits into
angular:masterfrom
btford:feat-router-deep-linking
Jul 1, 2015
Merged

btford merged 2 commits into
angular:masterfrom
btford:feat-router-deep-linking

Conversation

@btford

@btford btford commented Jun 29, 2015

Copy link
Copy Markdown
Contributor

Closes #2642

Review on Reviewable

@btford btford added comp: router action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 29, 2015
@btford btford added this to the alpha-28 milestone Jun 29, 2015
@btford
btford force-pushed the feat-router-deep-linking branch from 559e5ee to f257074 Compare June 29, 2015 20:34
@btford btford modified the milestones: alpha-29, alpha-28 Jun 29, 2015
@btford
btford force-pushed the feat-router-deep-linking branch from f257074 to f3c532e Compare June 29, 2015 20:55
@btford

btford commented Jun 29, 2015

Copy link
Copy Markdown
Contributor Author

Still working on this, but early feedback welcome. Hoping to finish by EOD.

@IgorMinar

Copy link
Copy Markdown
Contributor

Review status: 0 of 10 files reviewed at latest revision, 6 unresolved discussions, some commit checks failed.


modules/angular2/src/router/path_recognizer.ts, line 159 [r1] (raw file):
can you type the handler symbol and then use handler.component and handler.type instead of reflective calls? or is there some other reason (other than lack of type info) for doing it this way?


modules/angular2/src/router/path_recognizer.ts, line 187 [r1] (raw file):
trailing slash? I though we said that we wouldn't do trailing slashes


modules/angular2/src/router/route_registry.ts, line 153 [r1] (raw file):
linkDsl => linkParams?


modules/angular2/src/router/route_registry.ts, line 172 [r1] (raw file):
what do you need to do with params here? I thought that it was the componentRecognizer.generate that took care of params


modules/angular2/src/router/router_link.ts, line 41 [r1] (raw file):
isn't this linkParams rather than route?


modules/angular2/test/router/outlet_spec.ts, line 197 [r1] (raw file):
:-)


Comments from the review on Reviewable.io

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis is sad because this variable is unused.

@btford
btford force-pushed the feat-router-deep-linking branch from f3c532e to f4b5011 Compare June 30, 2015 17:10
@btford

btford commented Jun 30, 2015

Copy link
Copy Markdown
Contributor Author

Review status: 0 of 15 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


modules/angular2/src/router/path_recognizer.ts, line 187 [r1] (raw file):
This is joining on /, not joining with / at the end.


modules/angular2/src/router/route_registry.ts, line 172 [r1] (raw file):
This TODO is totally out of date.


Comments from the review on Reviewable.io

@btford

btford commented Jun 30, 2015

Copy link
Copy Markdown
Contributor Author

@btford
btford force-pushed the feat-router-deep-linking branch 8 times, most recently from 65fdad8 to a8938b2 Compare July 1, 2015 00:03
@btford
btford force-pushed the feat-router-deep-linking branch from a8938b2 to f66ce09 Compare July 1, 2015 00:22
@btford
btford merged commit f66ce09 into angular:master Jul 1, 2015
@btford
btford deleted the feat-router-deep-linking branch October 23, 2015 13:04
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(router): deep-linking

3 participants