Repository navigation
feat(router): support deep-linking to anywhere in the app - #2772
Conversation
559e5ee to
f257074
Compare
f257074 to
f3c532e
Compare
|
Still working on this, but early feedback welcome. Hoping to finish by EOD. |
|
Review status: 0 of 10 files reviewed at latest revision, 6 unresolved discussions, some commit checks failed. modules/angular2/src/router/path_recognizer.ts, line 159 [r1] (raw file): modules/angular2/src/router/path_recognizer.ts, line 187 [r1] (raw file): modules/angular2/src/router/route_registry.ts, line 153 [r1] (raw file): modules/angular2/src/router/route_registry.ts, line 172 [r1] (raw file): modules/angular2/src/router/router_link.ts, line 41 [r1] (raw file): modules/angular2/test/router/outlet_spec.ts, line 197 [r1] (raw file): Comments from the review on Reviewable.io |
There was a problem hiding this comment.
travis is sad because this variable is unused.
f3c532e to
f4b5011
Compare
|
Review status: 0 of 15 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed. modules/angular2/src/router/path_recognizer.ts, line 187 [r1] (raw file): modules/angular2/src/router/route_registry.ts, line 172 [r1] (raw file): Comments from the review on Reviewable.io |
|
modules/angular2/test/router/outlet_spec.ts, line 197 [r1] (raw file): Comments from the review on Reviewable.io |
65fdad8 to
a8938b2
Compare
a8938b2 to
f66ce09
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Closes #2642