fix(router): ensure URL is updated after second redirect with UrlUpda by jasonaden · Pull Request #27680 · angular/angular

jasonaden · 2018-12-14T18:08:30Z

teStrategy="eager"

Navigating to a route such as /users, you may get redirected to /login. Previously, if you go then route to /users again the URL will end up showing /users after the second redirect. This only happened in UrlUpdateStrategy="eager". This is now fixed so after the second redirect, the URL shows the correct page.

Patch version of #27523

googlebot · 2018-12-14T18:10:21Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

mary-poppins · 2018-12-14T18:12:38Z

You can preview 6771ed2 at https://pr27680-6771ed2.ngbuilds.io/.

googlebot · 2018-12-14T18:32:22Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

mhevery · 2018-12-14T18:34:20Z

http://test/OCL:225564788:BASE:225564895:1544812444438:71aa889f

googlebot · 2018-12-20T22:19:03Z

CLAs look good, thanks!

mary-poppins · 2018-12-20T22:23:24Z

You can preview 95dc4b0 at https://pr27680-95dc4b0.ngbuilds.io/.

…teStrategy="eager" Navigating to a route such as `/users`, you may get redirected to `/login`. Previously, if you go then route to `/users` again the URL will end up showing `/users` after the second redirect. This only happened in `UrlUpdateStrategy="eager"`. This is now fixed so after the second redirect, the URL shows the correct page. Fixes angular#27116

googlebot · 2018-12-21T22:26:13Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

mary-poppins · 2018-12-21T22:28:23Z

You can preview c01311f at https://pr27680-c01311f.ngbuilds.io/.

googlebot · 2019-01-04T20:03:44Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

kara · 2019-01-04T22:15:06Z

@jasonaden FYI moving out of merge queue because it still needs approval from @alxhub

jasonaden · 2019-01-14T21:57:24Z

Caretaker, please merge this. It's just the patch version of #27523 created to help with resolving conflicts.

…teStrategy="eager" (#27680) Navigating to a route such as `/users`, you may get redirected to `/login`. Previously, if you go then route to `/users` again the URL will end up showing `/users` after the second redirect. This only happened in `UrlUpdateStrategy="eager"`. This is now fixed so after the second redirect, the URL shows the correct page. Fixes #27116 PR Close #27680

AndrewKushnir · 2019-01-15T01:22:52Z

Merged this PR into patch branch using merge script.

…teStrategy="eager" (#27680) Navigating to a route such as `/users`, you may get redirected to `/login`. Previously, if you go then route to `/users` again the URL will end up showing `/users` after the second redirect. This only happened in `UrlUpdateStrategy="eager"`. This is now fixed so after the second redirect, the URL shows the correct page. Fixes #27116 PR Close #27680

With angular#27680, a bug was fixed where multiple redirects using `eager` URL update could cause navigation to fail. However, that fix introduced a problem where with `skipLocationChange` enabled, the URL tree rendered was not properly stored for reference. This specifically caused an issue with named router outlets and subsequent navigations not being recognized. This PR stores the correct `UrlTree` for reference with later navigations. It fixes the regression introdued with angular#27680. Fixes angular#28200

With #27680, a bug was fixed where multiple redirects using `eager` URL update could cause navigation to fail. However, that fix introduced a problem where with `skipLocationChange` enabled, the URL tree rendered was not properly stored for reference. This specifically caused an issue with named router outlets and subsequent navigations not being recognized. This PR stores the correct `UrlTree` for reference with later navigations. It fixes the regression introdued with #27680. Fixes #28200 PR Close #28301

With #27680, a bug was fixed where multiple redirects using `eager` URL update could cause navigation to fail. However, that fix introduced a problem where with `skipLocationChange` enabled, the URL tree rendered was not properly stored for reference. This specifically caused an issue with named router outlets and subsequent navigations not being recognized. This PR stores the correct `UrlTree` for reference with later navigations. It fixes the regression introdued with #27680. Fixes #28200 PR Close #28300

With angular#27680, a bug was fixed where multiple redirects using `eager` URL update could cause navigation to fail. However, that fix introduced a problem where with `skipLocationChange` enabled, the URL tree rendered was not properly stored for reference. This specifically caused an issue with named router outlets and subsequent navigations not being recognized. This PR stores the correct `UrlTree` for reference with later navigations. It fixes the regression introdued with angular#27680. Fixes angular#28200 PR Close angular#28300

angular-automatic-lock-bot · 2019-09-14T13:22:19Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

jasonaden changed the base branch from master to 7.1.x December 14, 2018 18:08

jasonaden requested a review from mhevery December 14, 2018 18:09

jasonaden added type: bug/fix area: router labels Dec 14, 2018

ngbot Bot added this to the needsTriage milestone Dec 14, 2018

jasonaden added action: merge The PR is ready for merge by the caretaker PR target: patch-only labels Dec 14, 2018

googlebot added the cla: no label Dec 14, 2018

mhevery added cla: yes and removed cla: no labels Dec 14, 2018

mhevery added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 14, 2018

mhevery requested review from IgorMinar and removed request for mhevery December 19, 2018 22:34

IgorMinar requested review from alxhub and removed request for IgorMinar December 20, 2018 00:10

jasonaden added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 20, 2018

jasonaden force-pushed the FW-46_early_url_cancellation_patch branch from 6771ed2 to 95dc4b0 Compare December 20, 2018 22:19

jasonaden force-pushed the FW-46_early_url_cancellation_patch branch from 95dc4b0 to c01311f Compare December 21, 2018 22:23

googlebot added cla: no and removed cla: yes labels Dec 21, 2018

jasonaden changed the base branch from 7.1.x to 7.2.x January 2, 2019 14:10

benlesh approved these changes Jan 3, 2019

View reviewed changes

kara added cla: yes and removed cla: no labels Jan 4, 2019

kara assigned kara and alxhub and unassigned kara Jan 4, 2019

AndrewKushnir closed this Jan 15, 2019

jasonaden mentioned this pull request Jan 22, 2019

fix(router): skipLocationChange with named outlets #28300

Closed

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019

Navigation Menu

fix(router): ensure URL is updated after second redirect with UrlUpda - #27680

fix(router): ensure URL is updated after second redirect with UrlUpda#27680
jasonaden wants to merge 1 commit into
angular:7.2.xfrom
jasonaden:FW-46_early_url_cancellation_patch

jasonaden commented Dec 14, 2018

Uh oh!

googlebot commented Dec 14, 2018

Uh oh!

mary-poppins commented Dec 14, 2018

Uh oh!

googlebot commented Dec 14, 2018

Uh oh!

mhevery commented Dec 14, 2018

Uh oh!

googlebot commented Dec 20, 2018

Uh oh!

mary-poppins commented Dec 20, 2018

Uh oh!

googlebot commented Dec 21, 2018

Uh oh!

mary-poppins commented Dec 21, 2018

Uh oh!

googlebot commented Jan 4, 2019

Uh oh!

kara commented Jan 4, 2019

Uh oh!

jasonaden commented Jan 14, 2019

Uh oh!

AndrewKushnir commented Jan 15, 2019

Uh oh!

angular-automatic-lock-bot Bot commented Sep 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

jasonaden commented Dec 14, 2018

Uh oh!

googlebot commented Dec 14, 2018

Uh oh!

mary-poppins commented Dec 14, 2018

Uh oh!

googlebot commented Dec 14, 2018

Uh oh!

mhevery commented Dec 14, 2018

Uh oh!

googlebot commented Dec 20, 2018

Uh oh!

mary-poppins commented Dec 20, 2018

Uh oh!

googlebot commented Dec 21, 2018

Uh oh!

mary-poppins commented Dec 21, 2018

Uh oh!

googlebot commented Jan 4, 2019

Uh oh!

kara commented Jan 4, 2019

Uh oh!

jasonaden commented Jan 14, 2019

Uh oh!

AndrewKushnir commented Jan 15, 2019

Uh oh!

angular-automatic-lock-bot Bot commented Sep 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants