Repository navigation
fix(docs): To run js test 'gulp docs' should be executed - #2762
Closed
alfonso-presa wants to merge 1 commit into
Closed
alfonso-presa wants to merge 1 commit into
alfonso-presa wants to merge 1 commit into
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
alfonso-presa
force-pushed
the
DocumentsBuildDocs
branch
from
June 28, 2015 22:14
54a3691 to
61c1be1
Compare
|
CLAs look good, thanks! |
tbosch
added
the
action: review
Contributor
|
LGTM |
petebacondarwin
added
action: merge
Contributor
Author
|
Thanks! :-) |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was not able to succesfully complete the tests without generating the docs by running 'gulp docs'.... Did I made something wrong?
I think that running 'gulp docs' is needed for the test suite to complete ('npm test'), because 'test.typings' task is included in the 'test.js' task, but docs are not generated by the 'build' task. It would be good to have this documented in the DEVELOPERS.md file.
Thanks!