Skip to content

fix(SelectControlValueAccessor): inject Renderer - #2759

Closed
PatrickJS wants to merge 1 commit into
angular:masterfrom
PatrickJS:patch-13
Closed

PatrickJS wants to merge 1 commit into
angular:masterfrom
PatrickJS:patch-13

Conversation

@PatrickJS

Copy link
Copy Markdown
Contributor

same problem and fix as #2757 and #2758

Review on Reviewable

@tbosch

tbosch commented Jun 29, 2015

Copy link
Copy Markdown
Contributor

Could you create 1 PR out of the 3?
Please also make sure that you don't import anything from angular2/angular2.
And could you rename the commit to "Remove cyclic dependency"

@tbosch tbosch added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jun 29, 2015
@PatrickJS

Copy link
Copy Markdown
Contributor Author

kool, I merged them

close in favor for #2856

@PatrickJS PatrickJS closed this Jul 2, 2015
@PatrickJS
PatrickJS deleted the patch-13 branch July 2, 2015 21:23
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants