Conversation
|
You can preview 4b04ed9 at https://pr27489-4b04ed9.ngbuilds.io/. |
alexeagle
force-pushed
the
skylint
branch
2 times, most recently
from
December 5, 2018 20:42
3d3ba63 to
e8427dc
Compare
|
You can preview e8427dc at https://pr27489-e8427dc.ngbuilds.io/. |
|
You can preview 417e4f9 at https://pr27489-417e4f9.ngbuilds.io/. |
Switch from Skylint to buildifier --lint - this is required for the Bazel 0.20 upgrade since Bazel no longer lets us use the embedded JDK to build and run Java programs, and Skylint is a Java program
|
You can preview f552501 at https://pr27489-f552501.ngbuilds.io/. |
IgorMinar
approved these changes
Dec 7, 2018
IgorMinar
added
action: merge
alxhub
pushed a commit
that referenced
this pull request
Dec 7, 2018
Switch from Skylint to buildifier --lint - this is required for the Bazel 0.20 upgrade since Bazel no longer lets us use the embedded JDK to build and run Java programs, and Skylint is a Java program PR Close #27489
alxhub
pushed a commit
that referenced
this pull request
Dec 7, 2018
alxhub
pushed a commit
that referenced
this pull request
Dec 7, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from Skylint to buildifier --lint - this is required for the Bazel 0.20 upgrade since Bazel no longer lets us use the embedded JDK to build and run Java programs, and Skylint is a Java program