Skip to content

build: update to Bazel 0.20 - #27394

Closed
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:update_bazel
Closed

alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:update_bazel

Conversation

@alexeagle

Copy link
Copy Markdown
Contributor

Introduce a .bazelrc.user file for user- or team-specific settings

Comment thread .bazelrc Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#27358 introduces this change.

Comment thread .gitignore Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#27358 introduces this.

@mgechev mgechev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left two comments related to the changes that #27358 introduces.

@mary-poppins

Copy link
Copy Markdown

You can preview 95b7b52 at https://pr27394-95b7b52.ngbuilds.io/.

@mary-poppins

Copy link
Copy Markdown

You can preview 9eeb6ee at https://pr27394-9eeb6ee.ngbuilds.io/.

@mgechev

mgechev commented Dec 3, 2018

Copy link
Copy Markdown
Member

Few CIs are failing lint complains for an environment variable, test for a missing dependency, same for build-packages-dist.

@mary-poppins

Copy link
Copy Markdown

You can preview 8584b5b at https://pr27394-8584b5b.ngbuilds.io/.

@mary-poppins

Copy link
Copy Markdown

You can preview bbe228a at https://pr27394-bbe228a.ngbuilds.io/.

@alexeagle

Copy link
Copy Markdown
Contributor Author

The lint job is blocked on switching from skylint (Java) to buildifier (binary release)
#27489

@googlebot

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Dec 7, 2018
@mary-poppins

Copy link
Copy Markdown

You can preview 006d587 at https://pr27394-006d587.ngbuilds.io/.

@mary-poppins

Copy link
Copy Markdown

You can preview 9391559 at https://pr27394-9391559.ngbuilds.io/.

@mary-poppins

Copy link
Copy Markdown

You can preview 33b173e at https://pr27394-33b173e.ngbuilds.io/.

@mary-poppins

Copy link
Copy Markdown

You can preview d3701e9 at https://pr27394-d3701e9.ngbuilds.io/.

refactor Bazel RBE configs
@mary-poppins

Copy link
Copy Markdown

You can preview 1397249 at https://pr27394-1397249.ngbuilds.io/.

@mary-poppins

Copy link
Copy Markdown

You can preview cd09702 at https://pr27394-cd09702.ngbuilds.io/.

@alexeagle alexeagle added the target: patch This PR is targeted for the next patch release label Dec 7, 2018
@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Dec 7, 2018
alxhub pushed a commit that referenced this pull request Dec 7, 2018
refactor Bazel RBE configs

PR Close #27394
@alxhub alxhub closed this in 44dd764 Dec 7, 2018
@IgorMinar IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 8, 2018
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants