Conversation
There was a problem hiding this comment.
should make a service account just for developer remote caching I think
There was a problem hiding this comment.
add the indirection so that we don't try to maintain code in user's un-versioned files (the remote_http_cache key in particular)
alexeagle
added
merge: caretaker note
There was a problem hiding this comment.
putting it in the users global .bazelrc doesn't work, because in some other workspace where I run bazel I get
ERROR: Config value angular-team is not defined in any .rc file
Instead we should instruct users to create a .bazelrc.user file in the root of their Angular project, which we add to .gitignore, and they should put this line in that file.
Then to get that file included in the Bazel options, add a line to the checked-in .bazelrc like
# Load any settings specific to the current user
try-import .bazelrc.user
see https://docs.bazel.build/versions/master/best-practices.html#bazelrc
There was a problem hiding this comment.
extra e - this doesn't match any files (both on this line and the line above)
There was a problem hiding this comment.
nit: leading space on this line
There was a problem hiding this comment.
nit: "project" is badly overloaded, I'd say "workspace" or maybe even "next to the .bazelrc file"
alexeagle
added
the
merge: caretaker note
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
This PR has no description as to what kind of assistance you need from a caretaker. Please provide one. |
|
I suggest that you rebase this PR on top of master because most of the CI failures are due to npm registry removing the malicious event-stream package. |
This PR introduces: 1. Google Cloud Store bucket which contains build artifacts 2. Documentation on how to enable remote caching in development Each team member should download a service key. More convenient ways of authentication would be more obscure and prevent us from doing identity tracking of the produced artifacts.
alexeagle
removed
the
merge: caretaker note
This PR introduces: 1. Google Cloud Store bucket which contains build artifacts 2. Documentation on how to enable remote caching in development Each team member should download a service key. More convenient ways of authentication would be more obscure and prevent us from doing identity tracking of the produced artifacts. PR Close #27358
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
This PR introduces:
Each team member should download a service key. More convenient ways of authentication would be more obscure and prevent us from doing identity tracking of the produced artifacts.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No remote caching for Angular core developers.
What is the new behavior?
Enables remote caching.
Does this PR introduce a breaking change?
Other information