feat: remove @angular/http by CaerusKaru · Pull Request #27038 · angular/angular

CaerusKaru · 2018-11-10T03:38:56Z

BREAKING CHANGE:

This removes @angular/http from the list of supported Angular core APIs. The new official API for HTTP in Angular is @angular/common/http

IgorMinar · 2018-11-15T17:31:10Z

I'd love for this to happen in v8! Would you be willing to work through the cleanup, writing up migration instructions for anyone still using the old http, and get this PR into a mergable state?

IgorMinar

We are almost there!! Can you please fix the following:

git grep "@angular/http" | grep -v CHANGELOG.md


.github/CODEOWNERS:#  @angular/http
aio/tools/examples/shared/boilerplate/service-worker/package.json:    "@angular/http": "^7.0.0",
integration/platform-server/yarn.lock:"@angular/http@file:../../dist/packages-dist/http":
modules/playground/src/web_workers/worker-systemjs-configure.ts:    '@angular/http': '/packages-dist/http/bundles/http.umd.js',
packages/platform-server/package.json:    "@angular/http": "0.0.0-PLACEHOLDER",

Also, I looked into google3 and there is still a lot of usage of this package, so we'll need to figure out a plan for that. My current thinking is that unlike with other changes, we'll delete this package from github and schedule a google3 cleanup for after v8.

Lastly, similar to the DOCUMENT PR, please change the commit message type to "feat".

CaerusKaru · 2019-01-14T09:05:33Z

@IgorMinar added remaining files, ready for another look!

alexeagle · 2019-03-05T22:05:38Z

Could you please split it into two:

remove any references to old http in our code, but still keep the implementation. This lets us still publish @angular/http for v8 if needed
PR that actually deletes the package in case of victory

CaerusKaru · 2019-03-17T03:15:15Z

@alexeagle I've opened #29355. We've already migrated all of the docs in AIO, and platform-server can't be migrated until we remove Http entirely (although technically we could: this is up to @IgorMinar).

ankeshdave · 2019-04-11T09:16:33Z

Will angular not support @angular/http in v8. Any clarity around this will help of people decide on migration strategy (I still have some projects were migrations is pending).

petebacondarwin · 2019-10-07T08:08:28Z

@CaerusKaru - where are we at with this PR? It needs a rebase but it is not clear to me whether you successfully split the changes into two as requested by @alexeagle ?

CaerusKaru · 2020-01-16T21:19:53Z

@petebacondarwin This PR hasn't been rebased on top of #29355, which is the split @alexeagle mentioned. Rebasing at this point would be tricky and I might just start from scratch, but only with commitment from the team that this is still needed.

CaerusKaru · 2020-01-22T02:53:35Z

Blocked on #34892 and #34814

kara · 2020-04-28T17:48:03Z

@CaerusKaru Rebase?

kara

LGTM

IgorMinar

LGTM! Thank you for being super patient!

The merging of this PR is still blocked on a config change CL in google3 that @matsko is landing right now.

Reviewed-for: global-approvers

kara · 2020-05-04T23:29:23Z

G3 change should be in, so this is unblocked

matsko · 2020-05-04T23:36:39Z

@kara @IgorMinar unfortunately the G3 change is causing files to be removed. We can't merge this yet.

matsko · 2020-05-05T18:41:58Z

This is now unblocked because G3 doesn't sync @angular/http anymore.

Here's the latest sync (of this PR) that proves it: https://critique-ng.corp.google.com/cl/309988926

The legacy HTTP package was deprecated in v5 with the launch of @angular/common/http. The legacy package hasn't been published since v7, and will therefore not include a migration.

angular-automatic-lock-bot · 2020-06-06T16:09:42Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Nov 10, 2018

CaerusKaru force-pushed the adam/http branch 18 times, most recently from c7533da to fb7d915 Compare November 13, 2018 04:30

IgorMinar added this to the v8-candidates milestone Nov 15, 2018

ngbot Bot removed this from the v8-candidates milestone Nov 15, 2018

IgorMinar added this to the v8-candidates milestone Nov 15, 2018

ngbot Bot removed this from the v8-candidates milestone Nov 15, 2018

IgorMinar added this to the v8-candidates milestone Nov 16, 2018

ngbot Bot removed this from the v8-candidates milestone Nov 16, 2018

IgorMinar added this to the v8-candidates milestone Nov 16, 2018

ngbot Bot removed this from the v8-candidates milestone Nov 16, 2018

IgorMinar added this to the v8-candidates milestone Nov 16, 2018

ngbot Bot removed this from the v8-candidates milestone Nov 16, 2018

CaerusKaru requested review from a team January 6, 2019 04:50

CaerusKaru force-pushed the adam/http branch 2 times, most recently from 590f2ff to 5a182d2 Compare January 8, 2019 01:19

CaerusKaru force-pushed the adam/http branch from 5a182d2 to 8bc9ac2 Compare January 13, 2019 18:18

CaerusKaru requested a review from a team January 13, 2019 18:18

CaerusKaru changed the title ~~refactor: remove @angular/http~~ build: remove @angular/http Jan 13, 2019

CaerusKaru changed the title ~~build: remove @angular/http~~ refactor: remove @angular/http Jan 13, 2019

IgorMinar suggested changes Jan 14, 2019

View reviewed changes

Comment thread packages/platform-server/src/location.ts Outdated

CaerusKaru force-pushed the adam/http branch from 8bc9ac2 to 09c4c1f Compare January 14, 2019 09:00

CaerusKaru mentioned this pull request Jan 14, 2019

compat: manage deprecation path migration #28133

Closed

CaerusKaru mentioned this pull request Jan 22, 2019

docs: Bump angular-in-memory-web-api to latest version for examples #28294

Closed

CaerusKaru mentioned this pull request Jan 16, 2020

refactor(http): fix a strictBindCallApply issue. #34817

Closed

1 task done

CaerusKaru mentioned this pull request Jan 22, 2020

build: remove @angular/http from modules #34892

Closed

3 of 14 tasks

kara approved these changes May 1, 2020

View reviewed changes

IgorMinar approved these changes May 4, 2020

View reviewed changes

feat: remove @angular/http

dd32648

The legacy HTTP package was deprecated in v5 with the launch of @angular/common/http. The legacy package hasn't been published since v7, and will therefore not include a migration.

IgorMinar mentioned this pull request May 16, 2020

fix(dev-infra): misc fixes for the compare master and patch script #37150

Closed

2 of 3 tasks

Conversation

CaerusKaru commented Nov 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IgorMinar commented Nov 15, 2018

Uh oh!

IgorMinar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CaerusKaru commented Jan 14, 2019

Uh oh!

alexeagle commented Mar 5, 2019

Uh oh!

CaerusKaru commented Mar 17, 2019

Uh oh!

ankeshdave commented Apr 11, 2019

Uh oh!

petebacondarwin commented Oct 7, 2019

Uh oh!

CaerusKaru commented Jan 16, 2020

Uh oh!

CaerusKaru commented Jan 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kara commented Apr 28, 2020

Uh oh!

kara left a comment

Choose a reason for hiding this comment

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

kara commented May 4, 2020

Uh oh!

matsko commented May 4, 2020

Uh oh!

matsko commented May 5, 2020

Uh oh!

angular-automatic-lock-bot Bot commented Jun 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

CaerusKaru commented Nov 10, 2018 •

edited

Loading

IgorMinar left a comment •

edited

Loading

CaerusKaru commented Jan 22, 2020 •

edited

Loading