Skip to content

refactor(DirectiveMetadata): make _hostRegExp private - #2694

Closed
vicb wants to merge 1 commit into
angular:masterfrom
vicb:0623-hre
Closed

vicb wants to merge 1 commit into
angular:masterfrom
vicb:0623-hre

Conversation

@vicb

@vicb vicb commented Jun 23, 2015

Copy link
Copy Markdown
Contributor

fixes #2691

@vicb vicb added comp: core action: review The PR is still awaiting reviews from at least one requested reviewer refactoring Issue that involves refactoring or code-cleanup labels Jun 23, 2015
@pkozlowski-opensource

Copy link
Copy Markdown
Member

@vicb this LGTM but I wonder if this is needed. This var is not exported so it is file-private (at least in JS!) - which is what we need, right? I guess special care needs to be taken for Dart, right? Since in JS no-one could import it anyway (?).

@vicb

vicb commented Jun 23, 2015

Copy link
Copy Markdown
Contributor Author

Dart would export any non private ("_" prefixed) var

@vicb

vicb commented Jun 23, 2015

Copy link
Copy Markdown
Contributor Author

see #2695

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes refactoring Issue that involves refactoring or code-cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does this need to be public? hostRegExp (src/render/api.ts)

4 participants