organize and update deprecation summary by jenniferfell · Pull Request #26733 · angular/angular

jenniferfell · 2018-10-24T22:56:01Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
[X ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
[X ] Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

There is no consolidated list of deprecated features, with version deprecated and replacement info/link. The API List can be filtered to show only deprecated APIs. Deprecated APIs are shown with strikethrough in search, API List, and package overview pages.

Issue Number: #26585

What is the new behavior?

Deprecated APIs and features are summarized in one place, with link to other places as needed.
Easy to tell when something was deprecated (or when it will be removed).

Does this PR introduce a breaking change?

Yes
No

Other information

jenniferfell · 2018-10-24T22:56:40Z

WIP: Still gathering information and related links. Not ready for review.

mary-poppins · 2018-10-24T23:01:04Z

You can preview f7af4f4 at https://pr26733-f7af4f4.ngbuilds.io/.

jenniferfell · 2018-10-25T19:18:17Z

note to self: add https://github.com/angular/quickstart/blob/master/README.md

jenniferfell · 2018-10-25T19:27:10Z

Also related for follow-up: #22640

mary-poppins · 2018-10-25T19:33:45Z

You can preview dda7c9e at https://pr26733-dda7c9e.ngbuilds.io/.

mary-poppins · 2018-10-25T19:58:48Z

You can preview 9c2ffdb at https://pr26733-9c2ffdb.ngbuilds.io/.

mary-poppins · 2018-11-15T19:19:47Z

You can preview 4b9a8ba at https://pr26733-4b9a8ba.ngbuilds.io/.

jenniferfell · 2019-04-24T23:25:27Z

The latest commit has the loadChildren changes suggested by @trotyl. Keeping as separate commit until I hear back from engineering.

The latest commit also has a fix to misspelling of "Compilation."

mary-poppins · 2019-04-24T23:30:46Z

You can preview eb4c9b5 at https://pr26733-eb4c9b5.ngbuilds.io/.

IgorMinar

posting the feedback I have so far.. still working through the rest.

…otes

Co-Authored-By: jenniferfell <[email protected]>

feedback addressed

mary-poppins · 2019-04-25T06:19:13Z

You can preview 19d03e0 at https://pr26733-19d03e0.ngbuilds.io/.

IgorMinar

this looks good now! I still have a few nits (H4s -> H3s, and add a bit more space in front of each H3 to visually separate the items in the doc) but those changes can be done in a follow up PR.

IgorMinar · 2019-04-25T06:32:18Z

+
+
+
+#### @angular/common


are these intentionally H4s? The consequence of H4 is that they don't show up in TOC which is a shame. could this be made H3s in a followup PR? thanks!

…26733) PR Close #26733

Co-Authored-By: jenniferfell <[email protected]> PR Close #26733

PR Close #26733

…otes (angular#26733) PR Close angular#26733

…ngular#26733) PR Close angular#26733

Co-Authored-By: jenniferfell <[email protected]> PR Close angular#26733

PR Close angular#26733

angular-automatic-lock-bot · 2019-09-15T03:22:25Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Oct 24, 2018

jenniferfell added state: WIP comp: docs labels Oct 24, 2018

ngbot Bot added this to the needsTriage milestone Oct 24, 2018

jenniferfell added target: patch This PR is targeted for the next patch release feature Label used to distinguish feature request from other issues labels Oct 25, 2018

jenniferfell mentioned this pull request Oct 25, 2018

Angular 4, deprecated code not summarized #15556

Closed

jenniferfell force-pushed the jfell-deprecation branch from f7af4f4 to dda7c9e Compare October 25, 2018 19:29

brandonroberts added effort2: days risk: low docsarea: release-info labels Nov 15, 2018

ngbot Bot modified the milestones: needsTriage, Backlog Nov 15, 2018

jenniferfell force-pushed the jfell-deprecation branch from 9c2ffdb to 4b9a8ba Compare November 15, 2018 19:11

trotyl reviewed Nov 16, 2018

View reviewed changes

Comment thread aio/content/guide/deprecation.md Outdated

Comment thread aio/content/guide/deprecation.md Outdated

Comment thread aio/content/guide/deprecation.md Outdated

petebacondarwin modified the milestones: Backlog, docs-infra-tooling Jan 10, 2019

jenniferfell force-pushed the jfell-deprecation branch from 4b9a8ba to baea845 Compare January 25, 2019 00:21

jenniferfell requested a review from IgorMinar as a code owner January 25, 2019 00:21

jenniferfell requested a review from a team January 25, 2019 00:21

jenniferfell force-pushed the jfell-deprecation branch 3 times, most recently from c1a3865 to d764b02 Compare February 5, 2019 19:14

jenniferfell added state: needs eng review Needs technical review and approval from engineering team state: blocked labels Apr 24, 2019

jenniferfell removed the state: blocked label Apr 25, 2019

IgorMinar suggested changes Apr 25, 2019

View reviewed changes

jenniferfell added 2 commits April 24, 2019 23:33

docs: clean up deprecation summary, remove outdated information and n…

6b3d0ec

…otes

docs: changed wording for loadChildren per reviewer comments on PR

64c76bb

jenniferfell force-pushed the jfell-deprecation branch 2 times, most recently from e4bb8f8 to 8a59f67 Compare April 25, 2019 06:04

docs: navigation and org changes, misc edits

23fa8e2

Co-Authored-By: jenniferfell <[email protected]>

jenniferfell force-pushed the jfell-deprecation branch from 8a59f67 to 23fa8e2 Compare April 25, 2019 06:06

docs: change anchor for removed section

ff21064

docs: fix link from release info to deprecations

19d03e0

IgorMinar approved these changes Apr 25, 2019

View reviewed changes

IgorMinar removed the request for review from brandonroberts April 25, 2019 06:33

IgorMinar added the action: merge The PR is ready for merge by the caretaker label Apr 25, 2019

AndrewKushnir closed this in 8b0ebe1 Apr 25, 2019

AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2019

docs: changed wording for loadChildren per reviewer comments on PR (#…

169d51b

…26733) PR Close #26733

AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2019

docs: navigation and org changes, misc edits (#26733)

bb47ad2

Co-Authored-By: jenniferfell <[email protected]> PR Close #26733

AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2019

docs: change anchor for removed section (#26733)

28e6aa7

PR Close #26733

AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2019

docs: fix link from release info to deprecations (#26733)

9e85d7f

PR Close #26733

BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019

docs: clean up deprecation summary, remove outdated information and n…

3527e0a

…otes (angular#26733) PR Close angular#26733

BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019

docs: changed wording for loadChildren per reviewer comments on PR (a…

0795c8a

…ngular#26733) PR Close angular#26733

BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019

docs: navigation and org changes, misc edits (angular#26733)

dbed843

Co-Authored-By: jenniferfell <[email protected]> PR Close angular#26733

BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019

docs: change anchor for removed section (angular#26733)

a869a81

PR Close angular#26733

BioPhoton pushed a commit to BioPhoton/angular that referenced this pull request May 21, 2019

docs: fix link from release info to deprecations (angular#26733)

a2d7467

PR Close angular#26733




		#### @angular/common

Conversation

jenniferfell commented Oct 24, 2018

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

jenniferfell commented Oct 24, 2018

Uh oh!

mary-poppins commented Oct 24, 2018

Uh oh!

jenniferfell commented Oct 25, 2018

Uh oh!

jenniferfell commented Oct 25, 2018

Uh oh!

mary-poppins commented Oct 25, 2018

Uh oh!

mary-poppins commented Oct 25, 2018

Uh oh!

mary-poppins commented Nov 15, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jenniferfell commented Apr 24, 2019

Uh oh!

mary-poppins commented Apr 24, 2019

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mary-poppins commented Apr 25, 2019

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

IgorMinar Apr 25, 2019

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot Bot commented Sep 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants