fix(aio): swap feature headers for divs to remove anchors#17156
Merged
Conversation
sjtrimble
added
comp: aio
action: review
|
The angular.io preview for 4d1b02d9b0d0bdb62385b043b341cf477189c055 is available here. |
…ture image resizing
sjtrimble
force-pushed
the
features-sans-headers
branch
from
4d1b02d to
3558e7e
Compare
gkalpak
approved these changes
Jun 1, 2017
| } | ||
|
|
||
| .feature-section img { | ||
| max-width: 70px; |
Member
There was a problem hiding this comment.
I think there needs to be some clean up wrt img styling. There seem to be rules scattered all over this file 😃
But not directly related to this PR.
gkalpak
added
action: merge
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…ture image resizing (angular#17156)
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…ture image resizing (angular#17156)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16824
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Anchors appear on headers when hovered upon.
What is the new behavior?
Headers have been substituted with divs and appropriate class and style which no longer show anchors when hovered upon.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: N/A