fix(aio): make the search-pane larger (and improve the search-box)#17105
Conversation
gkalpak
added
comp: aio
action: review
|
The angular.io preview for c641025822c0d83010d011418753e82172a5ccfc is available here. |
This enables browsers to style it better (e.g. add an `x` button for clearing the field, which allows users to quickly reset the search query and hide results).
gkalpak
force-pushed
the
fix-aio-larger-searchpane-on-mobile
branch
from
c641025 to
6f3c4ff
Compare
|
I still get a weird behavior I click it, it gets bigger. I click somewhere else and it gets super long and then goes back to normal. |
|
This PR does not fix that issue. It just makes the search-pane (where the results are shown) larger and makes the search input field |
|
Right right, my bad, I had that issue in mind only. My bad. |
petebacondarwin
changed the title
petebacondarwin
added
action: merge
|
Mergeable once the Travis flakes sort themselves out. |
|
The e2e2 Travis failures are "inherited" from master. The rest is green (now). |
…ngular#17105) * fix(aio): make the search-pane larger Fixes angular#17094 * feat(aio): give the search-box a type of "search" This enables browsers to style it better (e.g. add an `x` button for clearing the field, which allows users to quickly reset the search query and hide results).
…ngular#17105) * fix(aio): make the search-pane larger Fixes angular#17094 * feat(aio): give the search-box a type of "search" This enables browsers to style it better (e.g. add an `x` button for clearing the field, which allows users to quickly reset the search query and hide results).
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
6 participants
Fixes #17094.