feat(aio): provide noop service worker file#17032
Merged
Merged
Conversation
petebacondarwin
added
comp: aio
action: review
|
The angular.io preview for 7b3c46528205134c97c546a7f130e3c10088bd96 is available here. |
gkalpak
approved these changes
May 26, 2017
Member
There was a problem hiding this comment.
Not sure if it makes any difference in practice, but MDN seems to suggest using event.waitUntil(self.skipWaiting()).
Member
There was a problem hiding this comment.
If reloading feels too drastic, we can just "claim" the clients:
self.addEventListener('activate', function(event) {
event.waitUntil(self.clients.claim());
});
Contributor
Author
|
Happy to follow MDN. I was just copying someone else's code anyway. |
Use this file if we need to turn off the service worker in deployed sites in an emergency where the worker has a bug that is blocking the application from working. Closes angular#16897
petebacondarwin
force-pushed
the
aio-noop-sw
branch
from
7b3c465 to
f4a6d82
Compare
petebacondarwin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use this file if we need to turn off the service worker in deployed sites
in an emergency where the worker has a bug that is blocking the application
from working.
Closes #16897