fix(common): use correct ICU plural rules for all locales#16990
Merged
Conversation
ocombe
added
area: i18n
vicb
reviewed
May 24, 2017
vicb
reviewed
May 24, 2017
Contributor
There was a problem hiding this comment.
ignore my previous comment (this is generated code)
Contributor
|
needs tests ! |
ocombe
force-pushed
the
fix-plurals-script
branch
2 times, most recently
from
d85f8fb to
71f414f
Compare
vicb
reviewed
May 24, 2017
Contributor
There was a problem hiding this comment.
@ocombe I'm wondering if we should return one instead, could you please do some research to figure out ?
Contributor
Author
There was a problem hiding this comment.
Already checked the other day, it's always "other" when there is no rule in the spec
vicb
reviewed
May 24, 2017
Contributor
There was a problem hiding this comment.
"for a locale with no rule" ?
ocombe
force-pushed
the
fix-plurals-script
branch
3 times, most recently
from
400f566 to
4323b0a
Compare
vicb
reviewed
May 24, 2017
Locales with no rules were using the wrong plural rule instead of the default. The extraction script has been fixed and the localization file updated accordingly.
ocombe
force-pushed
the
fix-plurals-script
branch
from
4323b0a to
9e76676
Compare
vicb
removed
the
action: review
vicb
approved these changes
May 24, 2017
mhevery
approved these changes
May 24, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…angular#16990) Locales with no rules were using the wrong plural rule instead of the default.
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…angular#16990) Locales with no rules were using the wrong plural rule instead of the default.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What is the current behavior?
Some locales with empty plural rules were using the wrong plural rule instead of the default one because of a bug in the extraction script.
What is the new behavior?
The extraction script has been fixed and the localization file updated accordingly. All the locales that were miscategorized have been removed so that they now use the default rule.
I've also updated the script based on the changes that have been done to the localization script (even if the code is supposed to be generated, some people have changed the content without updating the script).
Does this PR introduce a breaking change?