feat(aio): close sidenav in narrow (mobile) mode when select a new doc#16617
Merged
Conversation
wardbell
added
comp: aio
action: review
|
The angular.io preview for 54da337864f37e30e6c97eceb788518c5170b34a is available here. |
wardbell
force-pushed
the
aio-close-sidenav-on-select
branch
from
54da337 to
fcaecd2
Compare
…cument closes angular#16603 As before this PR, when wide (side-by-side), the sidenav open/close status only changes when nav to/from marketing page in which case it opens for guide/api and closes for marketing page.
wardbell
force-pushed
the
aio-close-sidenav-on-select
branch
from
fcaecd2 to
cdae565
Compare
|
The angular.io preview for fcaecd29f2c5bf410c9d9dff15344d42bebeb7ed is available here. |
gkalpak
approved these changes
May 7, 2017
|
|
||
| this.navigationService.currentNode.subscribe(currentNode => { | ||
| this.currentNode = currentNode; | ||
| this.updateHostClasses(); |
Member
There was a problem hiding this comment.
This is unrelated to this PR, but it fixes another issue with styling applied prematurely (before the document is fetched). Maybe worth putting into a separate commit and test.
Contributor
Contributor
Author
There was a problem hiding this comment.
We agreed to let this request go and merge.
gkalpak
added
action: cleanup
petebacondarwin
approved these changes
May 8, 2017
wardbell
added
action: merge
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…cument (angular#16617) closes angular#16603 As before this PR, when wide (side-by-side), the sidenav open/close status only changes when nav to/from marketing page in which case it opens for guide/api and closes for marketing page.
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…cument (angular#16617) closes angular#16603 As before this PR, when wide (side-by-side), the sidenav open/close status only changes when nav to/from marketing page in which case it opens for guide/api and closes for marketing page.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #16603
This PR affects narrow (mobile) only. Now the sidenav closes when the current node (the current doc) changes.
Unchanged: when wide (side-by-side), the sidenav open/close status only changes when nav to/from marketing page in which case it opens for guide/api and closes for marketing page.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")