Skip to content

feat(aio): marketing design refresh#16228

Merged
petebacondarwin merged 1 commit into
angular:masterfrom
sjtrimble:design-refresh
May 27, 2017
Merged

feat(aio): marketing design refresh#16228
petebacondarwin merged 1 commit into
angular:masterfrom
sjtrimble:design-refresh

Conversation

@sjtrimble

@sjtrimble sjtrimble commented Apr 21, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

home page and sidenav layout and styling

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@mary-poppins

mary-poppins commented Apr 21, 2017

Copy link
Copy Markdown

The angular.io preview for 88649919f9f4c419863e8b2d4352dc641105fe8b is available here.

@sjtrimble sjtrimble force-pushed the design-refresh branch 2 times, most recently from 86cf434 to 99be689 Compare April 21, 2017 18:12
@mary-poppins

mary-poppins commented Apr 21, 2017

Copy link
Copy Markdown

The angular.io preview for 86cf43406b6edaf786e9f37cf19d6e3f0ea17fcb is available here.

@mary-poppins

mary-poppins commented Apr 21, 2017

Copy link
Copy Markdown

The angular.io preview for 99be689b1596ec0ee778754d67a919bb867c8e5e is available here.

@mary-poppins

mary-poppins commented Apr 21, 2017

Copy link
Copy Markdown

The angular.io preview for 5377386fe7ef36dde659e691e31805c4514b085b is available here.

@mary-poppins

mary-poppins commented Apr 21, 2017

Copy link
Copy Markdown

The angular.io preview for 7b51039b4f2f2f642d9f0f6195cafed2e7fdf1ae is available here.

@mary-poppins

mary-poppins commented Apr 22, 2017

Copy link
Copy Markdown

The angular.io preview for 4d6da37e06f76de4118aed450eb80c2a9ca6ecc8 is available here.

@sjtrimble sjtrimble force-pushed the design-refresh branch 2 times, most recently from 61a34b9 to 8ab6999 Compare April 24, 2017 17:32
@mary-poppins

mary-poppins commented Apr 24, 2017

Copy link
Copy Markdown

The angular.io preview for 8ab699914a8bd31953214cc64713742cb89159a2 is available here.

@mary-poppins

mary-poppins commented Apr 24, 2017

Copy link
Copy Markdown

The angular.io preview for 445725d997221d39f781e1f5bf45692455fe38ab is available here.

@wardbell

wardbell commented Apr 28, 2017

Copy link
Copy Markdown
Contributor

@sjtrimble I rebased for you, fixing a few things (like disabling the TOC for this page by adding the "no-toc" class to the <h1>.

The hamburger no longer displays although a big square invisible button is there in its place. Is that intentional?

@mary-poppins

mary-poppins commented Apr 28, 2017

Copy link
Copy Markdown

The angular.io preview for d5dc6826f18e12f5869ed95e41e32aeaf7c0ff88 is available here.

@sjtrimble sjtrimble force-pushed the design-refresh branch 5 times, most recently from 425cbc8 to d67de86 Compare May 4, 2017 17:11
@mary-poppins

mary-poppins commented May 4, 2017

Copy link
Copy Markdown

The angular.io preview for 425cbc80d36296638cd6ab97244d2b6da230b5fe is available here.

@mary-poppins

mary-poppins commented May 4, 2017

Copy link
Copy Markdown

The angular.io preview for d67de863401fd55bde4d31aa95de43d77f40c457 is available here.

@sjtrimble

sjtrimble commented May 25, 2017

Copy link
Copy Markdown
Contributor Author

@IgorMinar I removed the bottom slice on the home page and fixed the events table. I vote we move the about page to a different PR as this one's focus was mainly on the marketing pages.

@petebacondarwin Are you sure you want me to move the images to the content folder? Do you want them in the marketing folder, or...? I removed the hundreds of extra files.

@mary-poppins

mary-poppins commented May 25, 2017

Copy link
Copy Markdown

The angular.io preview for 1e503bf6b504cad5c1431ce43e6884022b77bd46 is available here.

@mary-poppins

mary-poppins commented May 25, 2017

Copy link
Copy Markdown

The angular.io preview for d779e8110d406febd77c152f13780c9ac876fd11 is available here.

@gkalpak gkalpak mentioned this pull request May 25, 2017
Closed
@petebacondarwin

petebacondarwin commented May 26, 2017

Copy link
Copy Markdown
Contributor

We decided that content specific images should be moved out of the assets folder, which should really only contain images that are general to the app shell. But I see that there is quite a mix of stuff in there right now. So instead I am going to create a post-release issue to move all that stuff around later.

This was referenced May 26, 2017
Closed
Closed
@petebacondarwin petebacondarwin dismissed their stale review May 26, 2017 21:17

The outstanding tasks have been moved to independent issues.

@mary-poppins

mary-poppins commented May 26, 2017

Copy link
Copy Markdown

The angular.io preview for 6c3d56193a181a059692a0bfd040fe1b7d809328 is available here.

@sjtrimble @petebacondarwin
feat(aio): marketing design refresh
bf50ce1 
- Add styling for active TOC item
- Add sidenav styles
- Change header tags to divs from index marketing page to remove anchors
- Fix use of card mixin and create separate card-docs class
- Add marketing styling
- Topnav styling when on home landing page
- Remove hamburger menu on home page
- Add fully rounded border to top nav toolbar search input
- Add mobile styles
- Add title banner to other marketing pages
@mary-poppins

mary-poppins commented May 26, 2017

Copy link
Copy Markdown

The angular.io preview for bf50ce1 is available here.

@Foxandxss Foxandxss added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 26, 2017
@petebacondarwin petebacondarwin merged commit b8b91d3 into angular:master May 27, 2017
@gkalpak gkalpak mentioned this pull request May 30, 2017
Merged
gkalpak added a commit to gkalpak/angular that referenced this pull request May 30, 2017
@gkalpak
fix(aio): fix ToC styling
7582674 
There seems to have been a bad rebase of angular#16228 on top of angular#16959, which affected
ToC styles from both PRs. This commit restores the horizontal line under `.h1`
elements and the vertical blue bar on the left-hand side of the ToC (with the
circle running along the bar to indicate the active section).

Fixes angular#17098
vicb pushed a commit that referenced this pull request May 30, 2017
@gkalpak @vicb
fix(aio): fix ToC styling (#17110)
0d894a1 
There seems to have been a bad rebase of #16228 on top of #16959, which affected
ToC styles from both PRs. This commit restores the horizontal line under `.h1`
elements and the vertical blue bar on the left-hand side of the ToC (with the
circle running along the bar to indicate the active section).

Fixes #17098
@sjtrimble sjtrimble changed the title WIP feat(aio): marketing design refresh feat(aio): marketing design refresh Jun 1, 2017
@sjtrimble sjtrimble mentioned this pull request Jun 1, 2017
Closed
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@gkalpak
fix(aio): fix ToC styling (angular#17110)
54904c4 
There seems to have been a bad rebase of angular#16228 on top of angular#16959, which affected
ToC styles from both PRs. This commit restores the horizontal line under `.h1`
elements and the vertical blue bar on the left-hand side of the ToC (with the
circle running along the bar to indicate the active section).

Fixes angular#17098
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@gkalpak @juleskremer
fix(aio): fix ToC styling (angular#17110)
d9afa57 
There seems to have been a bad rebase of angular#16228 on top of angular#16959, which affected
ToC styles from both PRs. This commit restores the horizontal line under `.h1`
elements and the vertical blue bar on the left-hand side of the ToC (with the
circle running along the bar to indicate the active section).

Fixes angular#17098
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 11, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@petebacondarwin petebacondarwin petebacondarwin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@sjtrimble sjtrimble

@juleskremer juleskremer

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sjtrimble @mary-poppins @wardbell @juleskremer @petebacondarwin @IgorMinar @Foxandxss @googlebot