Repository navigation
Provide a user-friendly way to get at Jasmine's done fn #8156
Description
The current thought is to have something similar to the internal AsyncTestCompleter but with a more user-friendly name:
it('is a test that explicitly needs done', inject([MyService, Done], (service, done) {
doComplicatedAsync()
.whenItsFinished(done)
.ifItFails(done.fail);
}));
Activity
vikerman commentedon Apr 21, 2016
One problem with the inject([Done]) pattern is that it makes inject() which is expected to be synchronous to an asynchronous test function. Can we make the Done concept associated with async instead of inject?
juliemr commentedon Apr 26, 2016
Will be resolved with #8257
juliemr commentedon Apr 28, 2016
Closing since that is merged. See https://github.com/vikerman/angular/blob/2dfffcd2eb1600bffcc043ce3cea53f4f84cd872/modules/angular2/test/testing/testing_public_spec.ts#L154 for an example of how to use this.
angular-automatic-lock-bot commentedon Sep 8, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.