Skip to content

feat(angular1_router): Add ng-link-active class to active ng-link - #6882

Closed
brandonroberts wants to merge 1 commit into
angular:masterfrom
brandonroberts:router1-ng-link-active
Closed

feat(angular1_router): Add ng-link-active class to active ng-link#6882
brandonroberts wants to merge 1 commit into
angular:masterfrom
brandonroberts:router1-ng-link-active

Conversation

@brandonroberts

@brandonroberts brandonroberts commented Feb 4, 2016

Copy link
Copy Markdown
Contributor

Closes #5286

@zoechi zoechi mentioned this pull request Feb 9, 2016
Closed
@btford

btford commented Feb 9, 2016

Copy link
Copy Markdown
Contributor

@brandonroberts 👍 this is a good addition.

@petebacondarwin – can you please help me review this? I cannot recall the best practice for efficiently dealing with watchers. I suspect there may be a slightly more efficient way of doing this.

@btford btford assigned petebacondarwin and unassigned btford Feb 9, 2016
@btford btford added comp: router feature Label used to distinguish feature request from other issues action: review The PR is still awaiting reviews from at least one requested reviewer effort1: hours labels Feb 9, 2016
@petebacondarwin

petebacondarwin commented Feb 9, 2016

Copy link
Copy Markdown
Contributor

I can't think of a more efficient watcher.
But I think we should be using ngAnimate to change the classes, right, so that the class changes can be animated... @matsko ?

@brandonroberts

brandonroberts commented Feb 17, 2016

Copy link
Copy Markdown
Contributor Author

Do I need to do anything else with this one?

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 25, 2016
@petebacondarwin petebacondarwin removed their assignment Feb 25, 2016
@petebacondarwin

petebacondarwin commented Feb 29, 2016

Copy link
Copy Markdown
Contributor

No, we just need to get it merged...

@petebacondarwin petebacondarwin added this to the beta.03 milestone Feb 29, 2016
@brandonroberts
brandonroberts force-pushed the router1-ng-link-active branch from d808d78 to a4e7866 Compare March 1, 2016 19:49
@brandonroberts
brandonroberts force-pushed the router1-ng-link-active branch from a4e7866 to c5328c7 Compare March 1, 2016 20:01
@mary-poppins

mary-poppins commented Mar 1, 2016

Copy link
Copy Markdown

Merging PR #6882 on behalf of @vsavkin to branch presubmit-vsavkin-pr-6882.

@vikerman

vikerman commented Mar 4, 2016

Copy link
Copy Markdown
Contributor

TAP Green

@mary-poppins

mary-poppins commented Mar 4, 2016

Copy link
Copy Markdown

Merging PR #6882 on behalf of @vikerman to branch presubmit-vikerman-pr-6882.

@mhevery mhevery closed this in 11e8aa2 Mar 4, 2016
@brandonroberts
brandonroberts deleted the router1-ng-link-active branch March 4, 2016 14:56
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 8, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours feature Label used to distinguish feature request from other issues

Projects

None yet

Milestone

beta.03

Development

See More

Successfully merging this pull request may close these issues.

feat(angular_1_router): Add class to active ng-link

8 participants

@brandonroberts @btford @petebacondarwin @mary-poppins @vikerman @vsavkin @naomiblack @googlebot