Repository navigation
Missing DI providers with beta 2 #6813
Description
We use TestComponentBuilder in our tests and after the upgrade to beta 2 the following providers won't be provided anymore automatically by angular:
- TestComponentBuilder
- DirectiveResolver
- ViewResolver
- DOCUMENT_TOKEN.
The problem is that DOCUMENT_TOKEN isn't in the codebase anymore; it used to reside in 'angular2/src/render/dom/dom_renderer'.
Furthermore, the Jasmine libraries won't be exported automatically anymore, either.
Activity
zoechi commentedon Feb 1, 2016
You are using the
TEST_BROWSER_XXX_PROVIDERSlike explained in b0cebdb ?See also https://github.com/angular/angular/blob/master/CHANGELOG.md#features
andrashatvani commentedon Feb 1, 2016
No, I missed the change. But after adding the required setup I see the following error reported by Karma:
Error: XHR error (404 Not Found) loading http://localhost:9876/angular2/platform/testing/browser
ericmdantas commentedon Feb 1, 2016
Same problem here with
TestComponentBuilderandjasmine's typings.brandonroberts commentedon Feb 1, 2016
The TEST_BROWSER_XXX_PROVIDERS didn't make it into the bundles: See #5351 (comment)
andrashatvani commentedon Feb 1, 2016
@brandonroberts What is the impact of the referenced issue on this one?
brandonroberts commentedon Feb 1, 2016
@andrashatvani You can't import TEST_BROWSER_XXX_PROVIDERS from angular2/platform/testing/browser which is why you were getting the 404.
andrashatvani commentedon Feb 1, 2016
@brandonroberts But these providers are there in angular2/platform/testing/browser
brandonroberts commentedon Feb 1, 2016
Ok, they must have updated the built bundles for beta.2.
brandonroberts commentedon Feb 1, 2016
@andrashatvani DOCUMENT_TOKEN is provided as DOCUMENT now from
angular2/platform/browserhttps://angular.io/docs/ts/latest/api/platform/browser/DOCUMENT-let.html
thorstenhans commentedon Feb 1, 2016
Both
TEST_BROWSER_PLATFORM_PROVIDERSandTEST_BROWSER_APPLICATION_PROVIDERSare there in the source but they didn't make it into the bundles. Is there a way how to fix this - at least locally?According to the ChangeLog they should be there https://github.com/angular/angular/blob/master/CHANGELOG.md#features
alexeagle commentedon Feb 1, 2016
I updated the bundles on code.angularjs.org.
Fix for the npm release will come this week in beta.3 (should be Wednesday)
meriturva commentedon Feb 2, 2016
Great we really need it fixed here as soon as possible! So thanks!
andrashatvani commentedon Feb 4, 2016
Verified fixed.
angular-automatic-lock-bot commentedon Sep 7, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.