Change @proxy() to @proxy #3494

Activity

1. yjbanov

   added

   type: bug/fix

   comp: core

   hotlist: GT

   P1: urgent

   effort1: hours

   on Aug 5, 2015
2. yjbanov

   assigned

   alexeagle

   on Aug 5, 2015
3. yjbanov

   added this to the alpha-35 milestone on Aug 5, 2015
4. alexeagle

   added a commit that references this issue on Aug 6, 2015

   fix(dart): @proxy is a value, not a factory

   ...

   This issue will close once commit b4a0629 is merged into the 'master' branch.

   b4a0629
5. alexeagle commented on Aug 6, 2015

   

   alexeagle

   on Aug 6, 2015

   Contributor

   More actions

   Why didn't any of our tests catch this defect?
6. yjbanov commented on Aug 6, 2015

   

   yjbanov

   on Aug 6, 2015

   ContributorAuthor

   More actions

   Probably some combination of the following:

   • we do not run Dart analyzer on the offending code (or it passes the analyzer check)
   • we do not compile our unit tests to JS
   • Dart VM doesn't care to eval @proxy because this annotation is not used at runtime (it's used for static analysis only) and therefore never fails any of our tests
7. alexeagle commented on Aug 6, 2015

   

   alexeagle

   on Aug 6, 2015

   Contributor

   More actions

   Is it because we don't run Dartium in checked mode for our testing? Can you
   fix that?

   On Thu, Aug 6, 2015 at 10:53 AM Yegor [email protected] wrote:

   Probably some combination of the following:

   • we do not run Dart analyzer on the offending code (or it passes the
     analyzer check)
   • we do not compile our unit tests to JS
   • Dart VM doesn't care to eval @proxy because this annotation is not
     used at runtime (it's used for static analysis only) and therefore never
     fails any of our tests

   —
   Reply to this email directly or view it on GitHub
   #3494 (comment).
8. alexeagle

   closed this as completedin #3504on Aug 6, 2015
9. angular-automatic-lock-bot commented on Sep 6, 2019

   

   angular-automatic-lock-botBot

   on Sep 6, 2019

   More actions

   This issue has been automatically locked due to inactivity.
   Please file a new issue if you are encountering a similar or related problem.

   Read more about our automatic conversation locking policy.

   _{This action has been performed automatically by a bot.}
10. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Sep 6, 2019