HTTP Headers .toJSON() only returns values (not keys) of the headers

The current implementation of toJSON() of the Headers class only returns a JSON-Object containing all values.:

[
  [
    "no-cache"
  ],
  [
    "application/json; charset=utf-8"
  ],
  [
    "no-cache"
  ],
  [
    "-1"
  ]
]

IMO this should return a JSON Object mapping keys to values.

@gdi2290

cc @gdi2290 - i know you added this for universal - any input?

yeah I can fix that. The idea behind having .toJSON() was being able to recreate it on the client

var serverHeaders = new Headers();
serverHeaders.append('Content-Type', 'image/jpeg');
var serialized = JSON.stringify(serverHeaders, null, 2);

console.log(serialized === `{
  "Content-Type": ["image/jpeg"]
}`);

var clientHeaders = new Headers(JSON.parse(serialized));

@choeller

@choeller @robwormald I have a PR with the correct implementation and tests to ensure that you can also recreate the Header #6714

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

Navigation Menu

Repository navigation

HTTP Headers .toJSON() only returns values (not keys) of the headers #6073

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

HTTP Headers .toJSON() only returns values (not keys) of the headers #6073

Description

Activity

robwormald commented on Dec 28, 2015

PatrickJS commented on Dec 29, 2015

PatrickJS commented on Jan 27, 2016

angular-automatic-lock-bot commented on Sep 7, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions