Skip to content

chore(bundle): determine if compiler barrel can be omitted #5815

Closed

Description

@jeffbcross

There are a handful of symbols exported from compiler.ts inside of angular2.ts which may not be necessary public APIs. We should decide if these symbols should be part of our public API, and whether the compiler barrel should be included in the angular2 bundle. If some symbols are required, perhaps a separate, more minimal barrel is warranted.

  • UrlResolver
  • AppRootUrl
  • getUrlScheme
  • DEFAULT_PACKAGE_URL_PROVIDER

I'll look at the core codebase to make sure these can be safely removed, and will check internally to make sure they are not depended on.

Activity

  1. self-assigned this
    on Dec 10, 2015
  2. added this to the beta.0 milestone on Dec 10, 2015
  3. jeffbcross commented on Dec 10, 2015

    @jeffbcross
    ContributorAuthor

    CC @tbosch @IgorMinar @vsavkin, save me some time if you know that one of these must be included in our public API.

  4. jeffbcross commented on Dec 10, 2015

    @jeffbcross
    ContributorAuthor
  5. jeffbcross commented on Dec 10, 2015

    @jeffbcross
    ContributorAuthor

    URLResolver is used in these places outside of tests and compiler src:

    • A couple of dart transformers
    • button_spec.ts and other material tests to provide a JS-&-Dart-friendly resolver for internal tests
    • worker.ts where it's just re-exported
    • playground/src/material/button/index.ts and other material examples where DemoUrlResolver is used instead.
    • Not present in angular/universal
    • There are a bunch of places internally that are overriding URLResolver for non-test code.

    Perhaps URLResolver can be moved to angular2/core?

  6. jeffbcross commented on Dec 10, 2015

    @jeffbcross
    ContributorAuthor

    AppRootUrl is used in these places outside of tests and compiler src:

  7. jeffbcross commented on Dec 10, 2015

    @jeffbcross
    ContributorAuthor

    I just talked IRL with @tbosch about all of these dependencies, and they could all be removed from the JS bundle. AppRootURL can be deleted, which I'll also do as part of this issue.

  8. added a commit that references this issue on Dec 11, 2015
    200dc00
  9. angular-automatic-lock-bot commented on Sep 7, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  10. locked and limited conversation to collaborators on Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area: build & ciRelated the build and CI infrastructure of the project

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions