You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(bundle): determine if compiler barrel can be omitted #5815
There are a handful of symbols exported from compiler.ts inside of angular2.ts which may not be necessary public APIs. We should decide if these symbols should be part of our public API, and whether the compiler barrel should be included in the angular2 bundle. If some symbols are required, perhaps a separate, more minimal barrel is warranted.
UrlResolver
AppRootUrl
getUrlScheme
DEFAULT_PACKAGE_URL_PROVIDER
I'll look at the core codebase to make sure these can be safely removed, and will check internally to make sure they are not depended on.
I just talked IRL with @tbosch about all of these dependencies, and they could all be removed from the JS bundle. AppRootURL can be deleted, which I'll also do as part of this issue.
Activity
jeffbcross commentedon Dec 10, 2015
CC @tbosch @IgorMinar @vsavkin, save me some time if you know that one of these must be included in our public API.
jeffbcross commentedon Dec 10, 2015
I should also check https://github.com/angular/universal
jeffbcross commentedon Dec 10, 2015
URLResolver is used in these places outside of tests and compiler src:
DemoUrlResolveris used instead.URLResolverfor non-test code.Perhaps URLResolver can be moved to
angular2/core?jeffbcross commentedon Dec 10, 2015
AppRootUrlis used in these places outside of tests and compiler src:jeffbcross commentedon Dec 10, 2015
I just talked IRL with @tbosch about all of these dependencies, and they could all be removed from the JS bundle. AppRootURL can be deleted, which I'll also do as part of this issue.
fix(angular2): remove `angular2.ts` module
fix(compiler): remove AppRootUrl
fix(web_workers): remove unnecessary setup module and AppRootUrl
fix(compiler): remove AppRootUrl
fix(web_workers): remove unnecessary setup module and AppRootUrl
angular-automatic-lock-bot commentedon Sep 7, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.