Repository navigation
Remove "upgrade" barrel from angular2/angular2 bundle #5739
Description
(Even putting aside the fact that angular2/angular2 goes away as a namespace we need to agree on content of the corresponding bundle)
As of today angular2/angular2 exports the upgrade barrel but discussing with @IgorMinar it looks like it should go away from a corresponding System.register bundle. The only alternative for ngUpgrade users is to use UMD bundles (angular2.umd.js)
This would be a breaking change for people that tried to use ngUpgrade with SystemJS loader and the current System.register bundles.
cc:// @wardbell @teropa @PascalPrecht - from our previous chat it looked like you've been teaching upgrade with SystemJS loader and TypeScript and not with ES5. If this is the case please speak up :-)
Metadata
Metadata
Assignees
Labels
No labels
Activity
teropa commentedon Dec 9, 2015
Yes, this is the case. At least in the TypeScript edition we import upgrade from
angular2/upgrade, after loadingangular2.dev.js.How is this going to change now?
pkozlowski-opensource commentedon Dec 9, 2015
@teropa so if I resolve this issue it would go away from the
angular2.dev.jsbundle. And since we don't publishupgradeas part of any other System.register bundle you pretty much wouldn't be able to load it through SystemJS. Unless we create a separate bundle for it, of course!I guess the main question here is this: do we want ngUpgrade users to use SystemJS + TypeScript? If so we need to either keep
angular2/upgradeas part of theangular2.dev.jsbundle (not big fan of this, as it adds bytes for everyone) or publish a separateupgrade.dev.jsbundle.IgorMinar commentedon Dec 9, 2015
Upgrade should be also published as a separate system register bundle. That
should solve this
On Wed, Dec 9, 2015 at 6:45 AM Tero Parviainen [email protected]
wrote:
0x-r4bbit commentedon Dec 9, 2015
I'd vote for publishing a separate bundle
teropa commentedon Dec 9, 2015
I like that idea too.
pkozlowski-opensource commentedon Dec 9, 2015
OK, a separate bundle then! Will need to clean-up its dependencies first as from my quick look it seems like there are some imports from angular2/angular2 in there (cycles!)
refactor(upgrade): remove imports from angular2/angular2
refactor(upgrade): remove imports from angular2/angular2
fix(bundles): remove ngUpgrade from the angular2.js bundle
pkozlowski-opensource commentedon Dec 14, 2015
This is covered in #5854
angular-automatic-lock-bot commentedon Sep 7, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.