feat(test): ability to configure providers on a per-spec basis #5128

Activity

1. btford

   added

   area: testingIssues related to Angular testing features, such as TestBedIssues related to Angular testing features, such as TestBed

   on Nov 4, 2015
2. juliemr

   self-assigned this

   on Nov 4, 2015
3. juliemr commented on Nov 19, 2015

   

   juliemr

   on Nov 19, 2015

   Contributor

   More actions

   Syntax proposal:

   it('should set up a provider for just one test', inject([A, B], (a, b) => {
     // do stuff
   }, () => [provide(A, {useValue: 'a'}), provide(B, {useClass: BImpl})]));

   or

   it('should set up a provider for just one test', withProviders(
     () => [provide(A, {useValue: 'a'}), provide(B, {useClass: BImpl})]
   ).inject([A, B], (a, b) => {
     // do stuff
   }));

   Thoughts? I'm partial to option 2 because the providers come first and it's more explicit what they're doing.
4. juliemr

   added

   state: Needs Design

   on Nov 19, 2015
5. btford commented on Nov 19, 2015

   

   btford

   on Nov 19, 2015

   ContributorAuthor

   More actions

   I also like option 2
6. juliemr commented on Nov 20, 2015

   

   juliemr

   on Nov 20, 2015

   Contributor

   More actions

   An additional thing to think about: eventually, when TS supports it, we'd like to be able to do:

   it("should do stuff", (@Inject() someInjectable: SomeInjectable) => {
   });

   I'm not sure if there'd be a nice way to fit per-spec providers in to that.
7. btford commented on Nov 21, 2015

   

   btford

   on Nov 21, 2015

   ContributorAuthor

   More actions

   I can think of several ways to add providers there, but none of them stick out as particularly nice. :/
8. juliemr commented on Dec 2, 2015

   

   juliemr

   on Dec 2, 2015

   Contributor

   More actions

   What about:

   // For now
   it('should set up a provider for just one test', withProviders(
     () => [provide(A, {useValue: 'a'}), provide(B, {useClass: BImpl})]
   ).inject([A, B], (a, b) => {
     // do stuff
   }));
   
   // In the future of TS
   it('should set up provider for just one test', withProviders(
     () => [provide(A, {useValue: 'a'}), provide(B, {useClass: BImpl})]
   ).run(@Inject(A) a, @Inject(B) b) => {
    // do stuff
   }));
9. btford commented on Dec 3, 2015

   

   btford

   on Dec 3, 2015

   ContributorAuthor

   More actions

   Works for me. I'm not too picky about the implementation.

   On Wed, Dec 2, 2015, 15:13 Julie Ralph [email protected] wrote:

   What about:

   // For now

   it('should set up a provider for just one test', withProviders(
   () => [provide(A, {useValue: 'a'}), provide(B, {useClass: BImpl})]
   ).inject([A, B], (a, b) => {
   // do stuff
   }));

   // In the future of TSit('should set up provider for just one test', withProviders(
   () => [provide(A, {useValue: 'a'}), provide(B, {useClass: BImpl})]
   ).run(@Inject(A) a, @Inject(B) b) => {
   // do stuff
   }));

   —

   Reply to this email directly or view it on GitHub
   #5128 (comment).
10. matsko

    closed this as completedin c1a0af5on Feb 20, 2016
11. angular-automatic-lock-bot commented on Sep 8, 2019

    

    angular-automatic-lock-botBot

    on Sep 8, 2019

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
12. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Sep 8, 2019