Skip to content

test(router): add tests for each location strategy #4935

Closed

Description

@btford

Originally, each location strategy only included a small amount of platform-specific behavior such that it was pragmatic to only test it as part of e2e tests.

In order to fix #4333, I had to abstract more behavior into the location strategies, such that many of the tests for Location were bogus.

Meanwhile, we have PR #3563 that does the needed refactoring to add a layer below location strategy so that we'd be able to test it.

As a part of #3563 we should include tests for the behaviors under test before #4333 was resolved.

Activity

  1. added this to the milestone on Oct 27, 2015
  2. angular-automatic-lock-bot commented on Sep 7, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  3. locked and limited conversation to collaborators on Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions