Skip to content

fix(benchmarks): update react and polymer benchmarks and get tree upd… - #4709

Closed
tbosch wants to merge 1 commit into
angular:masterfrom
tbosch:benchmarks
Closed

tbosch wants to merge 1 commit into
angular:masterfrom
tbosch:benchmarks

Conversation

@tbosch

@tbosch tbosch commented Oct 13, 2015

Copy link
Copy Markdown
Contributor

…ate numbers for all of the benchmarks as well.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the correct button?

@yjbanov

yjbanov commented Oct 16, 2015

Copy link
Copy Markdown
Contributor

If you think you're pressing the right buttons, then LGTM&merge.

@tbosch
tbosch force-pushed the benchmarks branch 2 times, most recently from 03cc2e1 to b08a7ab Compare October 16, 2015 17:29
@tbosch

tbosch commented Oct 28, 2015

Copy link
Copy Markdown
Contributor Author

Closes #960

@tbosch

tbosch commented Oct 28, 2015

Copy link
Copy Markdown
Contributor Author

Blocked by the router not working in Angular 1.4

Comment thread npm-shrinkwrap.json Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you forgot to bump the other angular-* packages, which is why the router tests fail.

…ate numbers for all of the benchmarks as well.
@tbosch tbosch closed this in bc10dc3 Oct 28, 2015
@tbosch
tbosch deleted the benchmarks branch October 28, 2015 20:17
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants